setUserVisibleHint called before onCreateView in Fragment

Question

I am working on ViewPager and using Fragment there I found

setUserVisibleHint() called before onCreateView() in Fragment

I am using Fragment from support library android.support.v4.app.Fragment

Is this is a problem with Library ?

How can I get rid of it ?

EDIT

I Override setUserVisibleHint() and not calling super to get rid of it.

@Override
public void setUserVisibleHint(boolean isVisibleToUser) {
    //FIXED: setUserVisibleHint() called before onCreateView() in Fragment causes NullPointerException
    //super.setUserVisibleHint(isVisibleToUser);
}

@shayanpourvatan we know that our view get inflated in onCreateView() later we use it; same thing I am creating Custom Veiw in onCreateView() and later have to use it in setUserVisibleHint() TRUE — Amit Yadav, Jun 11 '14 at 11:05
I use that method for refreshing data on fragment. if you need update or show your data you need check `getView()` on `setUserVisibleHint`, if is null, so `onCreateView` not called yet, and you can use that method from `onCreateView();` for first lunch or jumping some fragment, then change one Boolean value to Prevent duplicate calling method, i Hope this useful for you ( put refresh method in `onCreateView` and `setUserVisibleHint` ) — Shayan Pourvatan, Jun 11 '14 at 11:11
@AmitYadav have u got solution for ur problem..I am also facing similar problem mentioned here http://stackoverflow.com/q/25200404/2624806 — CoDe, Aug 11 '14 at 06:26
is this a google bug? its still happening.. why is that? i know how to implement workarounds, but do you have an idea why this is happening? — Martin Mlostek, Feb 08 '18 at 16:32

score 96 · Answer 1 · edited Dec 01 '15 at 17:35

96

// create boolean for fetching data
private boolean isViewShown = false;

@Override
public void setUserVisibleHint(boolean isVisibleToUser) {
    super.setUserVisibleHint(isVisibleToUser);
    if (getView() != null) {
        isViewShown = true;
        // fetchdata() contains logic to show data when page is selected mostly asynctask to fill the data
        fetchData();
    } else {
        isViewShown = false;
    }
}

Use isViewShown instance variable to decide whether to fetch data in onCreateView() or in setUserVisibleHint().

Below code contains logic for onCreateView():

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
        Bundle savedInstanceState) {
    View view = inflater.inflate(R.layout.main_layout, container, false);

   // view initialization steps.......

   if (!isViewShown) {
        fetchData();
   } 
   // do other stuff
}

This code will solve your problem. As It solved my problem. :)

This trick will fetch data in onCreateView() for direct jumping from one page to another, whereas when you swipe the view it will fetch the data from setUserVisibleHint() method. :)

edited Dec 01 '15 at 17:35

ahmed hamdy

5,096
1
47
58

answered Jul 24 '14 at 13:02

vikoo

2,451
20
27

But what does getView() do ? – Srikanth P Feb 06 '15 at 10:46
ensures the view is not null so you wont get NPE – Muli Yulzary Mar 10 '15 at 22:26
5

@vikoo Do you suggest that we are not supposed to check if `isVisibleToUser` is true or false??? In your first example Why didn't you check if `isVisibleToUser` is true then check if `getView()` is null.. – Karue Benson Karue May 15 '16 at 19:35
3

The isVisibleToUser flag is not trustworty in our app. We observer it becomes (sometimes, at least) true before the view is visible. I had to create a local flag as in this solution. Recommended. – carl Nov 24 '16 at 09:05
1

setUserVisibleHint works before onCreateView, this makes your answer wrong – Murat Apr 14 '17 at 08:34
Direct jumping is okay. But, this approach loads Data before fragment visible. Executing network call before arrived to respective fragment. Recommend this answer-> https://stackoverflow.com/a/32223340/8035209 – ZarNi Myo Sett Win May 07 '19 at 03:22

score 33 · Answer 2 · answered Aug 26 '15 at 09:52

you can use this logic, also you can turn off viewDidAppear any time by setting isVisible = false

public class MyFragment extends Fragment {
    private Boolean isStarted = false;
    private Boolean isVisible = false;

    @Override
    public void onStart() {
        super.onStart();
        isStarted = true;
        if (isVisible && isStarted){
            viewDidAppear();
        }
    }

    @Override
    public void setUserVisibleHint(boolean isVisibleToUser) {
        super.setUserVisibleHint(isVisibleToUser);
        isVisible = isVisibleToUser;
        if (isStarted && isVisible) {
            viewDidAppear();
        }
    }

    public void viewDidAppear() {
       // your logic
    }
}

as I remember this worked fine for me but feel free to edit the answer and add it — Fareed Alnamrouti, Oct 03 '17 at 06:14

score 15 · Answer 3 · answered Jul 01 '17 at 05:46

I found the best solution

private boolean isVisible;
private boolean isStarted;

@Override
public void onStart() {
    super.onStart();
    isStarted = true;
    if (isVisible)
        sendRequest(); //your request method
}

@Override
public void onStop() {
    super.onStop();
    isStarted = false;
}

@Override
public void setUserVisibleHint(boolean isVisibleToUser) {
    super.setUserVisibleHint(isVisibleToUser);
    isVisible = isVisibleToUser;
    if (isVisible && isStarted)
        sendRequest(); //your request method
}

It's improved version of fareed namrouti's answer. I tested this on many conditions. It's safe.

This works perfectly. I tested it too on viewpager. +1 I am confused little bit why we can't call onResume from parent fragment. — Pratik Saluja, Dec 23 '17 at 11:20

score 5 · Answer 4 · answered Nov 07 '16 at 15:34

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState) {
    View view = inflater.inflate(R.layout.fragment, container, false);

    if (getUserVisibleHint()) {
         sendRequest();
    }

    return view;
}

@Override
public void setUserVisibleHint(boolean isVisibleToUser) {
    super.setUserVisibleHint(isVisibleToUser);
    if (isVisibleToUser) {
        if (isResumed()){ 
             sendRequest();
          }
    }
}

Well, I have a problem with this, the onPreExecute method is not changing the visibility of my progress bar — JavierSegoviaCordoba, Jan 23 '18 at 14:06

score 3 · Answer 5 · answered Jan 17 '16 at 12:34

Below Worked for me....

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState)
{
    //// create class member variable to store view
    viewFrag =inflater.inflate(R.layout.fragment_main_favorite, container, false);

    // Inflate the layout for this fragment
    return viewFrag;
}

and use this

 @Override
    public void setUserVisibleHint(boolean visible)
    {
        super.setUserVisibleHint(visible);


            if (visible)
            {

                View v =  viewFrag ;
                if (v == null) {
                    Toast.makeText(getActivity(), "ERROR ", Toast.LENGTH_LONG ).show();
                    return;
                }
            }

    }

kuokuo · Answer 6 · 2016-01-14T14:36:34.203

My SightFragment.java here, should reset the flags in onDestroyView():

package cc.cubone.turbo.core.app;

import android.os.Bundle;
import android.support.v4.app.Fragment;
import android.view.View;

/**
 * Fragment for handling view after it has been created and visible to user for the first time.
 *
 * <p>Specially in {@link android.support.v4.view.ViewPager}, the page will be created beforehand
 * but not be visible to user.
 *
 * <p>Call {@link android.support.v4.view.ViewPager#setOffscreenPageLimit(int)} to set the number of
 * pages that should be retained.
 *
 * Reference:
 * <ul>
 * <li><a href="http://stackoverflow.com/questions/10024739/how-to-determine-when-fragment-becomes-visible-in-viewpager">
 * How to determine when Fragment becomes visible in ViewPager</a>
 * </ul>
 */
public class SightFragment extends Fragment {

    private boolean mUserSeen = false;
    private boolean mViewCreated = false;

    public SightFragment() {
    }

    /*public boolean isUserSeen() {
        return mUserSeen;
    }

    public boolean isViewCreated() {
        return mViewCreated;
    }*/

    @Override
    public void setUserVisibleHint(boolean isVisibleToUser) {
        super.setUserVisibleHint(isVisibleToUser);
        if (!mUserSeen && isVisibleToUser) {
            mUserSeen = true;
            onUserFirstSight();
            tryViewCreatedFirstSight();
        }
        onUserVisibleChanged(isVisibleToUser);
    }

    @Override
    public void onViewCreated(View view, Bundle savedInstanceState) {
        // Override this if you want to get savedInstanceState.
        mViewCreated = true;
        tryViewCreatedFirstSight();
    }

    @Override
    public void onDestroyView() {
        super.onDestroyView();
        mViewCreated = false;
        mUserSeen = false;
    }

    private void tryViewCreatedFirstSight() {
        if (mUserSeen && mViewCreated) {
            onViewCreatedFirstSight(getView());
        }
    }

    /**
     * Called when the new created view is visible to user for the first time.
     */
    protected void onViewCreatedFirstSight(View view) {
        // handling here
    }

    /**
     * Called when the fragment's UI is visible to user for the first time.
     *
     * <p>However, the view may not be created currently if in {@link android.support.v4.view.ViewPager}.
     */
    protected void onUserFirstSight() {
    }

    /**
     * Called when the visible state to user has been changed.
     */
    protected void onUserVisibleChanged(boolean visible) {
    }

}

score 1 · Answer 7 · answered Aug 29 '18 at 11:28

While most of this solutions work, you don't even need to track the state by yourself.

With current versions fo the support library there is a isResumed() method which does probably what most of you try to achieve by using an isStarted flag:

Return true if the fragment is in the resumed state. This is true for the duration of onResume() and onPause() as well.

And then it's as easy as:

    @Override
    public void setUserVisibleHint(boolean isVisibleToUser) {
        super.setUserVisibleHint(isVisibleToUser);
        if (isResumed()) {
            updateUi(isVisibleToUser);
        }
    }

score 1 · Answer 8 · answered May 14 '19 at 15:28

That simple variant work in my code:

@Override
public void onStart() {
    super.onStart();

    if (getUserVisibleHint()) {
        updateUI(); // your logic
    }
}

and

@Override
public void setUserVisibleHint(boolean isVisibleToUser) {
    super.setUserVisibleHint(isVisibleToUser);

    if (isResumed() && isVisibleToUser) {
       updateUI(); // your logic
    }
}

Rahul · Answer 9 · 2018-08-06T12:40:40.857

BELOW WORKED FOR ME

Please create a global view like this

private View view; 

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState)
    {
        //Inflate view layout
        view =inflater.inflate(R.layout.your_fragment, container, false);

        // return view
        return view;
    }

and use this

@Override
    public void setUserVisibleHint(boolean isUserVisible)
    {
        super.setUserVisibleHint(isUserVisible);
       //When fragment is visible to user and view is not null then enter here.
            if (isUserVisible && view != null)
            {
               // do your stuff here.
            }
    }

score 0 · Answer 10 · answered Jun 20 '17 at 02:55

Create this code in your setUserVisibleHint() :

if(isVisibleToUser && getView() != null){
        isActive = true;
        init();
    }else if(isVisibleToUser && getView() == null){
        isActive = false;
    }else{
        isActive = true;
    }

In your onCreateView() :

public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
if(!isActive){
        init();
    }
}

score 0 · Answer 11 · answered Jul 15 '20 at 11:02

The behavior that you are experiencing is specified in the documentation itself.

Note: This method may be called outside of the fragment lifecycle and thus has no ordering guarantees with regard to fragment lifecycle method calls.

Check it here. https://developer.android.com/reference/android/app/Fragment#setUserVisibleHint(boolean)

score 0 · Answer 12 · answered Mar 04 '21 at 14:22

0

Now, You no longer required to use this Method for FragmentPagerAdapter. It use send true for onView Screen and false for non-View Screen, while called for ViewPager Everytime.

Since Android have release LifeCycle in AndroidX, all lifecycle methods are called for visible screen. LifeCycle dont run after onCreateView for Non-Visible Screens in PagerAdapter.

This is for: ~Depricated setuservisiblehint

answered Mar 04 '21 at 14:22

Beatle Refractor

403
5
8

Get Your logic of setUserVisibilityHint on onStart method from now onwards. Refrain to monkey typing(copy paste) for logics – Beatle Refractor Mar 04 '21 at 14:24

score 0 · Answer 13 · answered Jun 22 '22 at 04:47

is hard to maintain and listen to a state, I use the hacky method to listen to visibility

For AndroidX Fragment

Initially, I put every show transaction, I added

fragment.userVisibleHint = true
currentFragment?.userVisibleHint = false
transaction.add(fragmentContainer.id, fragment, "tag").commit()

For hide/remove transactions, I added

currentFragment.userVisibleHint = false

In My Fragment/BaseFragment:

    class ExampleFragment:Fragment(){
        val visibilityStateChanges = MutableLiveData<Boolean>()
    
    override fun onCreateView(
            inflater: LayoutInflater,
            container: ViewGroup?,
            savedInstanceState: Bundle?,
        ): View? {
    
            visibilityStateChanges.value = true
            //return your view
        }
    
        override fun setUserVisibleHint(isVisibleToUser: Boolean) {
            super.setUserVisibleHint(isVisibleToUser)
            Log.e("JeyK", "isVisibleToUser $isVisibleToUser")
            visibilityStateChanges.value = isVisibleToUser
        }
    }
}

in your Fragment, you could observe the liveData to receive visibility states

visibilityStateChanges.observe(this@MapPathFinderFragment) {
            Log.e("visibilityStateChanges", "Visibility changed $it")
        }

hushed_voice · Answer 14 · 2018-08-29T12:02:33.593

-1

This is the best solution i found.

    @Override
    public void onCreateView() {
        super.onStart();
        if (getUserVisibilityHint()){
            //do stuff
        }
    }

    @Override
    public void setUserVisibleHint(boolean isVisibleToUser) {
        super.setUserVisibleHint(isVisibleToUser);
        if (isResumed() && isVisibleToUser) {
            //do stuff
        }
    }

edited Aug 29 '18 at 12:02

answered Dec 07 '17 at 15:14

hushed_voice

3,161
3
34
66

setUserVisibleHint called before onCreateView in Fragment

14 Answers14

Linked