undefined method `get?' for 302:Integer

Question

I like to upgrade the ruby version from 2.4.2 to 2.5.0 in my rails application.

All specs/tests fail where I use turbolinks. Is there a known issue with turbolinks and ruby 2.5.0?

Here is the output on the terminal.

Failure/Error: expect(request).to redirect_to company_salesmen_path(salesman.company)

NoMethodError:
    undefined method `get?' for 302:Integer
  # /Users/dennish/.rvm/gems/ruby-2.5.0/gems/turbolinks-5.1.0/lib/turbolinks/assertions.rb:37:in `turbolinks_request?'
  # /Users/dennish/.rvm/gems/ruby-2.5.0/gems/turbolinks-5.1.0/lib/turbolinks/assertions.rb:6:in `assert_redirected_to'
  # ./spec/requests/salesmen_spec.rb:206:in `block (3 levels) in <top (required)>'

This is the spec:

describe 'DELETE /salesman/:id' do
  subject(:request) do
    delete salesman_path(salesman), headers: auth_headers
  end

  let!(:salesman) { create :salesman }

  it 'destroys salesman' do
    expect { request }.to change { Salesman.count }.by(-1)
  end

  it 'redirects to index' do
    expect(request).to redirect_to company_salesmen_path(salesman.company)
  end
end

1. You should paste the error message in form of text, not as an image. 2. You should probably show how your `salesmen_spec.rb` file looks like. — Marek Lipka, Mar 15 '18 at 07:57
an issue has been filled: https://github.com/turbolinks/turbolinks-rails/issues/38 — coorasse, May 17 '18 at 13:50

davegson · Accepted Answer · 2019-07-12T08:50:18.810

4

The root cause of this error is:

subject(:request)

By assigning :request we are overwriting rails internals - hence it breaks and the tests fail wierdly.

The Solution

Just go with the default (no name)

subject { delete salesman_path(salesman) }

Or you can rename the subject:

subject(:http_request) { delete salesman_path(salesman) }

Both solutions will make the tests succeed.

edited Jul 12 '19 at 08:50

answered Jul 10 '19 at 12:41

davegson

8,205
4
51
71

score 3 · Answer 2 · answered Apr 14 '18 at 22:07

3

I had this same issue it seems to be a compatibility issue with Turbolinks 5.1 and Rails 5.0.x. Downgrading to Turbolinks 5.0.1 solved it for me.

answered Apr 14 '18 at 22:07

Jared

2,885
2
28
31

Looks like, this is the only way – DenicioCode Apr 17 '18 at 09:30

score 3 · Answer 3 · answered Nov 15 '18 at 14:43

3

By renaming the request to http_request is solving this.

answered Nov 15 '18 at 14:43

DenicioCode

8,668
4
18
33

undefined method `get?' for 302:Integer

3 Answers3

The Solution