Mapstruct is not updating its getters and setters in the generated source files

Question

I have an entity with a property I used to write like this private Long ICU;

I'm using mapstruct:

Here is my mapper for said entity:

@Mapper(componentModel = "spring")
public interface ProtectionQueryMapper extends EntityMapper<ProtectionQueryDto, Protection> {

    ProtectionQueryDto toDto(Protection protection);

    Protection toEntity(ProtectionQueryDto protectionQueryDto);

    List<Protection> toEntity(List<ProtectionQueryDto> protectionQueryDtos);

    List<ProtectionQueryDto> toDto(List<Protection> protections);

}

public interface EntityMapper<D, E> {

    E toEntity(D dto);

    D toDto(E entity);

    List<E> toEntity(List<D> dtoList);

    List<D> toDto(List<E> entityList);
}

The problem I have is that I want to change the property from ICU go icu, which I did and it resulted in this error:

nested exception is java.lang.NoSuchMethodError:

Protection.getICU()Ljava/lang/Long;

It would seem that mapstruct generated its getters and setters based on: private Long ICU; generating method like setICU and getICU. But now that I have changed the property from ICU to icu mapstruct is not updating its method to setIcu and getIcu.

I cannot change the mapstruct generated file manually.

Also here is my pom.xml (at least the part regarding mapstruct)

<dependency>
  <groupId>org.mapstruct</groupId>
  <artifactId>mapstruct</artifactId>  
  <version>1.3.0.Final</version>
</dependency>

              <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <configuration>
                    <source>1.8</source>
                    <target>1.8</target>
                    <annotationProcessorPaths>
                        <path>
                            <groupId>org.mapstruct</groupId>
                            <artifactId>mapstruct-processor</artifactId>
                            <version>1.3.0.Final</version>
                        </path>
                    </annotationProcessorPaths>
                    <compilerArgs>
                        <compilerArg>
                            <arg>-Amapstruct.defaultComponentModel=spring</arg>
                        </compilerArg>
                    </compilerArgs>
                </configuration>
            </plugin>

Any idea how to have mapstruct update its generated source file?

You could always add the `@Mapping` annotations for all non trivial mappings like `@Mapping(source = "icu", target = "ICU")` but this seems wrong... MapStruct should be case insensitive in such situation :/ — dbl, Jul 02 '19 at 09:53
try `mvn clean install`, mapper implementation classes are placed in target folder and they won't be updated unless you `mvn clean` your project resulting in removal of target folder — Mansoor Ali, Jul 02 '19 at 11:59
@burubum : running mvn clean compile seems to have fixed the issue, thanks. — Nicolas, Jul 02 '19 at 12:19

score 14 · Answer 1 · answered Feb 10 '21 at 14:38

You need to provide the lombok plugin first in order, then the mapstruct-processor plugin just like this.

<configuration>
    <source>1.8</source>
    <target>1.8</target>
    <annotationProcessorPaths>
        <path>
            <groupId>org.projectlombok</groupId>
            <artifactId>lombok</artifactId>
            <version>1.18.16</version>
        </path>
        <path>
            <groupId>org.mapstruct</groupId>
            <artifactId>mapstruct-processor</artifactId>
            <version>1.4.2.Final</version>
        </path>
    </annotationProcessorPaths>
</configuration>

So simple yet so important. Thank you. You saved me. – OctavioCega Mar 11 '21 at 10:20 — OctavioCega, Mar 11 '21 at 10:20

score 8 · Accepted Answer · answered Jul 03 '19 at 07:05

For some reason the recompile of the project didn't run the annotation processor. MapStruct is invoked by the Java compiler and the maven-compiler-plugin is responsible for cleaning up the folder with the generated classes.

Doing mvn clean compile will always work. However, if doing a change and then doing mvn compile doesn't, I would try with the latest version of the maven-compiler-plugin and if that still doesn't work create a bug report for the plugin.

score 2 · Answer 3 · answered Aug 04 '22 at 23:56

2

Thanks to https://stackoverflow.com/users/10467757/adil-aslam-sachwani for his answer about setting mapstruct processor after lombok's one. It worked for me, but I have it with gradle, so in that case, it should be like this:

implementation 'org.mapstruct:mapstruct:1.5.2.Final'
compileOnly 'org.projectlombok:lombok'
annotationProcessor 'org.projectlombok:lombok'
annotationProcessor 'org.mapstruct:mapstruct-processor:1.5.2.Final'

answered Aug 04 '22 at 23:56

cristianhoyos66

39
4

1

This worked for me after putting the mapstruct and lombok in correct order. thanks – Jimmy Feb 16 '23 at 10:22

score 1 · Answer 4 · edited Sep 10 '20 at 10:48

If you use Lombok for your entities and DTOs you have to update your pom.xml like this:

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <configuration>
                    <annotationProcessorPaths>
                        <path>
                            <groupId>org.mapstruct</groupId>
                            <artifactId>mapstruct-processor</artifactId>
                            <version>${mapstruct.version}</version>
                        </path>
                        <path>
                            <groupId>org.projectlombok</groupId>
                            <artifactId>lombok</artifactId>
                            <version>${lombok.version}</version>
                        </path>
                    </annotationProcessorPaths>
                    <compilerArgs>
                        <arg>-Amapstruct.defaultComponentModel=spring</arg>
                    </compilerArgs>
                </configuration>
            </plugin>

Then Mupstruct will be able to see their getters and setters.

(You can check my project and its demo to see this in action.)

Eduardo Nunes · Answer 5 · 2022-11-09T14:41:57.010

0

I know this is an old question, but after editing your pom.xml like Dan Dragut, and if you use intellij, try clicking on the hammer that is located on the left side of the "run" button, that will cause the project to be rebuilt, then your generated sources will be up to date again

edited Nov 09 '22 at 14:41

answered Nov 09 '22 at 14:37

Eduardo Nunes

3
4

The toolbar icons in IntelliJ and other IDEs can be customized, so please provide better description how to find the rebuild button or you can just suggest to use the rebuild functionality. – woytech Nov 13 '22 at 12:37

Mapstruct is not updating its getters and setters in the generated source files

5 Answers5

Linked