javascript function can find another function

Question

I have this below code in a javascript file. When i run it i get error message :

"Can't find variable: addZero".

function addZero(n) {
    return ( n < 0 || n > 9 ? "" : "0" ) + n;
}

Date.prototype.toISODate =
        new Function("with (this)\n    return " +
           "getFullYear()+'-'+ addZero(getMonth()+1)+ '-'" +
           "+ addZero(getDate()) + 'T' + addZero(getHours())+':' " +
           "+ addZero(getMinutes()) +':'+ addZero(getSeconds()) +'.000Z'");

I don't know what you are tying to do. but **you are doing it wrong!** — gdoron, May 01 '12 at 10:24
Any reason why you use `new Function` instead of defining a "normal" function? Is `addZero` in global scope? What's the context of this code? — Felix Kling, May 01 '12 at 10:25
Regarding to `with` you might want to read [this question](http://stackoverflow.com/q/9864026/601179) — gdoron, May 01 '12 at 10:33

score 1 · Answer 1 · answered May 01 '12 at 10:26

1

function addZero(n) {
    return ( n < 0 || n > 9 ? "" : "0" ) + n;
}

Date.prototype.toISODate = function() {
    // do what you want here
    // with real code! not strings...
}

answered May 01 '12 at 10:26

gdoron

147,333
58
291
367

are you suggesting some thing like Date.prototype.toISODate= function() { return getFullYear()+'-'+addZero(getMonth()+1)+ '-' +addZero(getDate())+'T'+addZero(getHours())+':' +addZero(getMinutes())+':'+addZero(getSeconds())+'.000Z'; } – Amit May 01 '12 at 10:28
@Amit. yes, something like that. But I still don't know what you're tying to do and if it's the best way of doing it. – gdoron May 01 '12 at 10:29

score 0 · Answer 2 · edited May 01 '12 at 10:33

0

Looks like your quotes are off. Try

return "with (this)\n    return " +
getFullYear() + '-' + addZero(getMonth()+1) + '-' +
addZero(getDate()) + 'T' + addZero(getHours())+':' +
addZero(getMinutes()) +':'+ addZero(getSeconds()) +'.000Z';

edited May 01 '12 at 10:33

gdoron

147,333
58
291
367

answered May 01 '12 at 10:28

Travis J

81,153
41
202
273

score 0 · Answer 3 · answered May 01 '12 at 10:29

Theres a good function on the Mozilla Javascript reference page for Date that produces ISO Date strings

https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference:Global_Objects:Date

    /* use a function for the exact format desired... */
function ISODateString(d){
  function pad(n){return n<10 ? '0'+n : n}
  return d.getUTCFullYear()+'-'
      + pad(d.getUTCMonth()+1)+'-'
      + pad(d.getUTCDate())+'T'
      + pad(d.getUTCHours())+':'
      + pad(d.getUTCMinutes())+':'
      + pad(d.getUTCSeconds())+'Z'
}

var d = new Date();
console.log(ISODateString(d)); // prints something like 2009-09-28T19:03:12Z

KooiInc · Answer 4 · 2012-05-01T12:30:37.627

Try rewriting your Date extension like this, to keep things clear and to avoid using the with keyword:

Date.prototype.toISODate =
  function(){

    function padLeft(nr,base,padStr){
        base = base || 10;
        padStr = padStr || '0';
        var  len = (String(base).length - String(nr).length)+1;
        return len > 0? new Array(len).join(padStr)+nr : nr;
    }    

    return [this.getFullYear(),
            '-',
            padLeft(this.getMonth()+1),
            '-',
            padLeft(this.getDate()),
            'T', 
            padLeft(this.getHours()),
            ':',
            padLeft(this.getMinutes()),
            ':',
            padLeft(this.getSeconds()),
            '.',
            padLeft(this.getMilliseconds(),100),
            'Z'].join('');
  };

The padLeftZero function now exists within the scope of the Date.toISODate method. The use of an array literal to build the return string is for clarity. It isn't necessary and even can be called bad practice to use new Function ... to assign a function to Date.prototype.toISODate. BTW, milliseconds are added to the result (padded with zero's).

javascript function can find another function

4 Answers4