Adding JFrame to Main GUI Frame from another class

Question

I have two classes. 1.One class contains all the GUI code generated by Netbeans GUI builder (call it GUI class) 2.Another class contains some code containing methods (SaveTraffic which extends SwingWorker).

In my SaveTraffic , I create a frame which just pops up and come in front of my GUI when I run my application. I want to add this frame to my GUI at the specific location where I want to place it. How is this possible? This is my code of SaveTraffic

public class SaveTraffic extends SwingWorker<Void, String> {

    public static int k = 0;
    public GUI f = new GUI();
    public static Frame u = new Frame();
    public static JTextArea h = new JTextArea();
    JScrollPane scrollPane2 = new JScrollPane(h, JScrollPane.VERTICAL_SCROLLBAR_ALWAYS,
            JScrollPane.HORIZONTAL_SCROLLBAR_ALWAYS);

    @Override
    public Void doInBackground() throws IOException {
        u.setSize(950, 200);
        u.setLocation(0,550);
        u.add(scrollPane2);
        u.setVisible(true);
        while (f.num() != 2) {
            {
              publish("Hello World");
            }
        }
        return null;
    } //end main function

    @Override
    public void process(List<String> chunks) {
        for (final String text : chunks) {
            Runnable r = new Runnable() {

                @Override
                public void run() {
                    h.setLineWrap(true);
                    h.append(text + "\n");
                }
            };
            new Thread(r).start();
        }
    }

    @Override
    public void done() {
        System.out.println("I am DONE");

    }
}

score 2 · Answer 1 · edited Jun 20 '20 at 09:12

I see several problems in your code:

You are looking for JDialog and not a new frame. Make sure to pass the correct Dialog owner to the constructor of JDialog. You can choose wheter the dialog is modal or not through a parameter on the constructor or by calling setModal().
You are starting new Threads inside the SwingWorker.publish method. Those thread modify the UI. Althout JTextArea.append is Thread-safe, I would still not use multiple Threads to update the JTextArea. It is unecessary and if some day you add some calls that are not Thread-safe you will end up on a deadlock.
You are adding components to your frame, setting its size and making it visible in the SwingWorker.doInBackground() which is not run on the EDT. Instead move that call before executing your SwingWorker, inside the EDT.
No need to constantly set the line wrap to true on the textarea. Just calling it once is enough.
I am not sure what 'k' is used for, but I would beware of static variables.
Why do you make your Frame and your TextArea static?

(Optional) I would also consider adding a constructor in SaveTraffic and initialize most of the code there.

score 2 · Answer 2 · edited May 23 '17 at 12:30

2

don't built Swing Gui inside SwingWorker's methods, SwingWorker is designated to add / modify / change value in JComponent(s) that already exist
add process() or publish() to the SwingWorker, inside this method put value or append text the JTextArea periodically
for "Monitoring" SwingWorker's statuses add PropertyChangeListener
simple example

edited May 23 '17 at 12:30

Community

1
1

answered May 21 '12 at 18:12

mKorbel

109,525
20
134
319

Good point on not creating the UI in SwingWorker. (although it would have never crossed my mind to do it there) +1 – Guillaume Polet May 21 '12 at 18:14

score 0 · Answer 3 · answered May 21 '12 at 17:36

0

You make a class, that extends JPanel. Then you do all your code in there, and bind it with your method class.

answered May 21 '12 at 17:36

OmniOwl

5,477
17
67
116

Adding JFrame to Main GUI Frame from another class

3 Answers3