@Autowired bean works with @Valid on controller but fails with CRUD repository

Question

I'm working on a Spring MVC + Hibernate + JPA app with a user registration form and I decided to use a JSR-303 validator to check whether the username already existed in the DB:

public class UniqueUsernameValidator implements ConstraintValidator<VerifyUniqueUsername, String> {

    @Autowired
    UserService userService;

    @Override
    public void initialize(VerifyUniqueUsername constraintAnnotation) {     
    }

    @Override
    public boolean isValid(String username, ConstraintValidatorContext context) {                       

        return  username!=null &&  userService.findByUsername(username) == null;        
    }
}

It is very straightforward and validation worked great on my controller:

....
    public String signup(@Valid @ModelAttribute("newUser") User user, BindingResult newUserBeanResult)
.....

The current problem I'm facing is that after I get my User object validated and I call:

userService.save(user);

Which implements CrudRepository, I get a NullPointerException. For some reason UserService is injected during validation on the controller but not when I call CrudRepository.save().

I saw similar posts such as this: @Autowired bean null in ConstraintValidator when invoked by Sessionfactory.getCurrentSession.merge and this: hibernate validator without using autowire but I was wondering if someone has run into this before. I would think that injecting beans to access the database on a validator is fairly common.

As a workaround I added a check for null on userService but it doesn't feel right.

Is this expected behaviour? Are these validations supossed to fire before calling CrudRepository.save()?
Am I suppossed to handle "manually" hibernate events? In this case pre-insert

score 3 · Accepted Answer · answered Dec 17 '12 at 23:53

I ended up solving this issue by instructing Spring's EntityManagerFactoryBean to use my validator bean (more accurately, hibernate will now be using Spring's validator):

<bean id="emf" class="org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean">
        <property name="dataSource" ref="dataSource" />
        <property name="jpaVendorAdapter">
            <bean class="org.springframework.orm.jpa.vendor.HibernateJpaVendorAdapter" />
        </property>        
        <property name="packagesToScan" value="some.packages"/>
        <property name="jpaPropertyMap">
            <map>
                <entry key="javax.persistence.validation.factory" value-ref="validator"  />           
            </map>
        </property>
        <property name="jpaProperties">
            <props>
                <prop key="hibernate.dialect">org.hibernate.dialect.MySQLDialect</prop>
                <prop key="hibernate.max_fetch_depth">3</prop>
                <prop key="hibernate.jdbc.fetch_size">50</prop>
                <prop key="hibernate.jdbc.batch_size">10</prop>
                <prop key="hibernate.show_sql">true</prop>              
            </props>        
        </property>
    </bean>

However, this threw a StackOverflow error :)

Apparently the cause of this issue was that my validator was using a finder method (findByUsername) and finder methods trigger a hibernate flush, which in turn triggers a validation. This loops indefinitely until you get the most famous exception there is.

So...I fixed this by changing the validators to use the EntityManager directly (instead of the CRUD repository) and temporarily change the FlushModeType to COMMIT. Here is the example:

public class UniqueUsernameValidator implements ConstraintValidator<UniqueUsername, String> {

    @PersistenceContext
    private EntityManager em;

    @Autowired
    UserService userService;

    @Override
    public void initialize(UniqueUsername constraintAnnotation) {       
    }

    @Override
    public boolean isValid(String username, ConstraintValidatorContext context) {
        try { 
            em.setFlushMode(FlushModeType.COMMIT);          
            return userService.findByUsername(username) == null;

            } finally { 
           em.setFlushMode(FlushModeType.AUTO);
           }    
    }
}

This solves the issue where the validator was using the finder function which triggered a hibernate flush which in turn was triggering the validator causing a StackOverflowError.

score 2 · Answer 2 · answered Jul 15 '12 at 17:14

2

When the validation logic is invoked in response to the save method it is done by hibernate. The validator object is created by hibernate so the spring @AutoWired will not work.

One option to fix this is to use the @Configurable annotation and enable load time weaving to make sure that even when hibernate instantiates the validator object spring gets to inject dependencies into it.

answered Jul 15 '12 at 17:14

gkamal

20,777
4
60
57

thanks for the suggestion, I'm fairly new to Spring I'll do some googling for @Configurable and get back to you guys. Thanks. – Ulises Jul 15 '12 at 21:45
I haven't had much luck, if you can point me somewhere where I could read more about this would be great. Thanks! – Ulises Jul 15 '12 at 22:34
http://stackoverflow.com/questions/4703206/spring-autowiring-using-configurable - this question has more details on how to setup @Configurable. It is used for entities - the same should work for Validators as well. – gkamal Jul 17 '12 at 16:41
http://aredko.blogspot.in/2011/02/using-configurable-in-spring-framework.html - one more example of how to setup @Configurable – gkamal Jul 17 '12 at 16:41
I stayed with xml configuration and fixed the issue, I'll post the answer when I get a chance. Thanks – Ulises Jul 23 '12 at 17:11

@Autowired bean works with @Valid on controller but fails with CRUD repository

2 Answers2

Linked