How to enable a WinForm button in time to receive focus by tabbing

Question

Visual Studio 2010, C#

I have a ComboBox with a DropDown, AutoComplete set to SuggestAppend and the AutoCompleteSource is from the ListItems. The user keys data into it until the have the correct entry. Utill the data matches one of the list items, a button next to the combobox is disabled.

If the user hits the tab key the autocomplete feature accepts current suggestion. It also moves on to the next control in tab sequence that is enabled. Of course since I want it to go to the disbabled button I need to enable it as soon as I validate the entry.

The problem is that none of the events I've tried, PreviewKeyDown, LostFocus, SelectedIndexChanged allow me to enable the button in time for it to be proccessed and receive the focus. It always goes to the next button in tab order which is always enabled.

I am about ready to leave the button enabled and have it give an error if pressed too soon but I don't want to do it that way. I also don't want to get into have special mode flags to keep track of when these controls receive focus. Validation seems to be a normal thing, but I'm stuck.

If the SelectedIndexChanged worked when the user made a match this would be easy. It doesn't fire when the box clears nor when a typed match is found.

score 1 · Answer 1 · answered Aug 10 '12 at 04:29

You could create your own ComboBox class to encapsulate this behavior. Something like this:

using System;
using System.Windows.Forms;

namespace WindowsFormsApplication1
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();

            this.myComboBox1.TheButton = this.button1;

            this.myComboBox1.Items.AddRange( new string[] {
                "Monday",
                "Tuesday",
                "Wednesday",
                "Thursday",
                "Friday",
                "Saturday",
                "Sunday"
            } );

            button1.Enabled = false;
        }
    }

    public class MyComboBox : ComboBox
    {
        public Control TheButton { get; set; }

        public MyComboBox()
        {
        }

        bool IsValidItemSelected
        {
            get { return null != this.SelectedItem; }
        }

        protected override void OnValidated( EventArgs e )
        {
            if ( null != TheButton )
            {
                TheButton.Enabled = this.IsValidItemSelected;
                TheButton.Focus();
            }

            base.OnValidated( e );
        }

        protected override void OnTextChanged( EventArgs e )
        {
            if ( null != TheButton )
            {
                TheButton.Enabled = this.IsValidItemSelected;
            }

            base.OnTextChanged( e );
        }
    }
}

Thank you for taking the time to create this. A problem is that the buttons focus is being set in the OnValidated event. The VS2010 Help states "Do not attempt to set focus from within the Enter, GotFocus, Leave, LostFocus, Validating, or Validated event handlers. Doing so can cause your application or the operating system to stop responding." Secondarily the validation events take place after the Leave event which is also too late, so it doesn't look like I can do what I want natively. — Rich Shealer, Aug 10 '12 at 12:41
"So it doesn't look like I can do what I want." The test application that I created in my answer does what you want. Did you try it? — ahazzah, Aug 10 '12 at 15:18
No I didn't because the caution seemed to be very specific. It does work. With a little more tweeking it would enable the button as soon as the user finishes typing. I do have another solution using a form override of ProcessCmdKey that doesn't violate the warning. I'm probably being over literal but I am new to .Net after working the last 15 years doing Win32 with Delphi and there are enough differences that I'm cautious. — Rich Shealer, Aug 10 '12 at 18:51

score 0 · Answer 2 · answered Aug 10 '12 at 04:13

0

try this :

key_press event :

if (e.KeyData == Keys.Enter)
        {
            button2.Enabled = true;
            button2.Focus();
        }

answered Aug 10 '12 at 04:13

Habib Zare

1,206
8
17

This doesn't act on the Tab key. Also the KeyPress event doesn't supply KeyData. – Rich Shealer Aug 10 '12 at 13:34

Stuart Helwig · Answer 3 · 2012-08-10T04:20:03.647

0

Instead of the event hanlders you mentioned, (LostFocus, SelectedIndexChanged and PreviewKeyDown) use the "Validated" event of your combobox to set the enabled state of the button.

You may need to also manually focus on the button to force the focus to move to it though.

e.g.

    private void comboBox1_Validated(object sender, EventArgs e)
    {
        button1.Enabled = true;
        button1.Focus();
    }

edited Aug 10 '12 at 04:20

answered Aug 10 '12 at 04:13

Stuart Helwig

9,318
8
51
67

1

Assigning the focus in validation assumes too much. Asumming it would stay there, what if the user clicked another button on the form? It is also warned against in the help. See my comment to ahazzah. – Rich Shealer Aug 10 '12 at 14:25
That is a fair call. I misunderstood what you meant by "I want it to go to the disabled button". After re-reading, it is clear that you mean, you want that behaviour if user hits tab key. – Stuart Helwig Aug 12 '12 at 08:45

Rich Shealer · Answer 4 · 2012-08-10T15:50:33.263

With some thought to the other answers here I came up with a partial senario that works without using AutoComplete. A side effect is that the PreviewKeyDown event is called a second time and therefore validation is called twice. I wonder why... maybe I should ask another question.

    private void comboBox1_PreviewKeyDown(object sender, PreviewKeyDownEventArgs e) {
      if (e.KeyData == Keys.Tab) {
        if (ValidationRoutine()) {
          e.IsInputKey = true;  //If Validated, signals KeyDown to examine this key
        } //Side effect - This event is called twice when IsInputKey is set to true
      }          
    }

    private void comboBox1_KeyDown(object sender, KeyEventArgs e) {
      if (e.KeyData == Keys.Tab) {
          e.SuppressKeyPress = true; //Stops further processing of the TAB key
          btnEdit.Enabled = true;
          btnEdit.Focus();
      }
    }

Once you turn on AutoCompleteMode with any setting other than None, the KeyDown event doesn't fire for Tab anymore the key is silently eaten.

How to enable a WinForm button in time to receive focus by tabbing

4 Answers4

Linked