OnCreateView called multiple times / Working with ActionBar and Fragments

Question

I switched part of my App from Activities to Fragments so that I can use the neat ActionBar tabs.

However, after completing the transition I ran into an issue: whenever I switch to another tab, that Fragment gets created all over again. Both onCreate and onCreateView get called every time I get to a tab.

I have 4 tabs, each of which is meant to open one of these fragments:

Fragment ShopFragment = new WebActivity();
Fragment SearchFragment = new SearchActivity(context);
Fragment StoreFragment = new StoreLocatorActivity(context, this);
Fragment BlogsFragment = new BlogsActivity(context, this);

Here's my code for the listener:

    class MyTabsListener implements ActionBar.TabListener {
        public Fragment fragment;

        public MyTabsListener(Fragment fragment) {
            this.fragment = fragment;
        }

        @Override
        public void onTabReselected(Tab tab, FragmentTransaction ft) {
            ft.hide(fragment);
        }

        @Override
        public void onTabSelected(Tab tab, FragmentTransaction ft) {
            ft.replace(R.id.fragment_container, fragment);
        }

        @Override
        public void onTabUnselected(Tab tab, FragmentTransaction ft) {          

        }

    }

Could someone please point me in the right direction?

Does anyone know how I could handle this please? – Sorin Cioban Aug 31 '12 at 06:52 — Sorin Cioban, Aug 31 '12 at 06:52

score 51 · Accepted Answer · edited May 09 '16 at 06:59

51

When you call FragmentTransaction.replace(...), Android will effectively perform a sequence of FragmentTransaction.remove(...) (for all Fragments currently added to that container) and FragmentTransaction.add(...) (for your supplied Fragment). Removing a Fragment from the FragmentManager will cause the Fragment to be destroyed and its state will no longer be managed. Most noticeably, when you re-add the Fragment all of the views will have been reset. Note: since you are reusing the same Fragment instance, the Fragment will still keep the value any instance variables.

One solution to this problem would be to use FragmentTransaction.detach(Fragment) and FragmentTransaction.attach(Fragment) when switching. This will cause the Fragment views to be recreated (onDestroyView() & onCreateView() will be called), but the instance state bundle will be saved and given back to you between calls and so the view state can be maintained. This is the approach taken by FragmentPagerAdapter when it tries to switch between Fragments.

Alternatively, you could allow the Fragments to be destroyed, but maintain their saved state for them independently. This would use less memory, at the expense of a slower switching time. Methods of note would be FragmentManager.saveFragmentInstanceState(Fragment) and FragmentManager.setInitialSavedState(Fragment.SavedState), in conjuction with adding/removing. This is the approach taken by FragmentStatePagerAdapter.

You can have a look at the source for FragmentPagerAdapter and the source for FragmentStatePagerAdapter for implementation hints.

edited May 09 '16 at 06:59

xiaomi

6,553
3
29
34

answered Sep 01 '12 at 14:08

antonyt

21,863
9
71
70

This is a workaround. onCreate and onCreateView are still getting called and saving states require much work. Isn't there a way to just keep the already painted view of wach fragment and just replace them? Why repaint them all over again? – AlikElzin-kilaka Dec 25 '12 at 18:53
Hi i'm using ActionBar Tabs and using attach and detach! Can you please explain with some sample code how can i save instance state when switching to other tab and then maintaining the state when coming back to tab! Thanks – Muhammad Babar Jun 23 '14 at 11:40
@kilaka Can you please explain how you get the `saving state` working? – Muhammad Babar Jun 23 '14 at 11:41
@MuhammadBabar - don't know. I use show/hide - http://stackoverflow.com/a/14033244/435605 – AlikElzin-kilaka Jun 23 '14 at 11:46
@kilaka but detach and attach are more efficient way than show and hide. I guess! – Muhammad Babar Jun 23 '14 at 11:48
@antonyt Can you please help? – Muhammad Babar Jun 23 '14 at 12:44
@MuhammadBabar create a question and describe what you have tried so far – antonyt Jun 23 '14 at 12:55
@antonyt I have solved it myself :) Anyway i appreciate your help. – Muhammad Babar Jun 23 '14 at 14:49

score 12 · Answer 2 · answered Dec 25 '12 at 19:00

12

There is the show/hide option just so the fragments would not need to be repainted/recreated and the onCreate() and onCreateView() won't be reinvoked.

answered Dec 25 '12 at 19:00

AlikElzin-kilaka

34,335
35
194
277

OnCreateView called multiple times / Working with ActionBar and Fragments

2 Answers2

Linked