keep viewdata on RedirectToAction

Question

[AcceptVerbs(HttpVerbs.Post)]
public ActionResult CreateUser([Bind(Exclude = "Id")] User user)
{
        ...
        db.SubmitChanges();
        ViewData["info"] = "The account has been created.";
        return RedirectToAction("Index", "Admin");
}

This doesnt keep the "info" text in the viewdata after the redirectToAction. How would I get around this issue in the most elegant way?

My current idea is to put the stuff from the Index controlleraction in a [NonAction] and call that method from both the Index action and in the CreateUser action, but I have a feeling there must be a better way.

Thanks.

score 89 · Accepted Answer · edited Jun 18 '10 at 00:05

89

You can use TempData.

TempData["info"] = "The account has been created.".

TempData exists exactly for this situation. It uses Session as storage, but it will not be around after the second response.

From MSDN:

A typical use for a TempDataDictionary object is to pass data from an action method when it redirects to another action method. For example, an action method might store information about an error in the controller's TempData property (which returns a TempDataDictionary object) before it calls the RedirectToAction method. The next action method can then handle the error and render a view that displays an error message.

edited Jun 18 '10 at 00:05

p.campbell

98,673
67
256
322

answered Aug 04 '09 at 08:52

Mathias F

15,906
22
89
159

Interesting, never heard of it. :-) – Thomas Stock Aug 04 '09 at 08:58
2

it's a bummer tho that you have to use "TempData" in the view too, and can't just keep using ViewData there. But it works nicely, so thanks. – Thomas Stock Aug 04 '09 at 09:01
See the copy extension method http://blog.eworldui.net/post/2008/06/MVC-Post-Redirect-Get-Sample-Updated.aspx – James S Aug 04 '09 at 09:26

score 13 · Answer 2 · answered Aug 04 '09 at 09:00

13

Use ViewData if your data should be accessible in View during "this" request. Use `TempData' if your data is for "next" request (for example POST-REDIRECT-GET design pattern).

answered Aug 04 '09 at 09:00

eu-ge-ne

28,023
6
71
62

score 2 · Answer 3 · answered Oct 26 '09 at 14:52

If you need this more than once, a nice workaround would be creating ActionFilterAttributes which export/import the tempdata to viewdata and vice-versa. You can pass your ModelState in this way very nicely as well (demonstrated here - #13). With a few adjustments to that piece of code you would have a clean solution, I think.

Christ A · Answer 4 · 2015-11-15T12:05:00.093

You could use the TempData controller property, but it has the disadvantage that it uses the session storage in the background. This means that you'll have extra work getting it to function on a web farm and you'll need to have sessions enabled in your application in the first place.

An alternative is to use cookies if you only need to transport a short message. This does require proper encryption of the cookie. Not relying on the TempData property also allows you to set messages in a non MVC context, for example in a classic ASHX page.

Take a look at FlashMessage which can save you some work implementing this yourself.

score 1 · Answer 5 · answered Jun 24 '14 at 18:30

1

Since TempData appears to use storage, and any form of ITempDataProvider that is not "in-process", requires the object to be Serializable, TempData seems woefully inadequate in web farm situations... (ViewDataDictionary isn't itself serializable...) Does anyone have any suggestions for this?

answered Jun 24 '14 at 18:30

Novox

774
2
7
24

I'm looking into this now. The data is going to have to go via the client if you're using a RedirectToAction. So I think that leaves us with only 'RouteValues' - which equates to QueryString, or Cookies! – Ian Grainger Dec 12 '18 at 11:59

Wael Moughrbel · Answer 6 · 2022-06-22T13:46:28.347

0

The answer is TempData. The usage difference for clarification is as the following:

TempData = passing data from Action to another Action

ViewData = passing data from Action to a View

edited Jun 22 '22 at 13:46

answered Apr 21 '22 at 09:42

Wael Moughrbel

214
1
3
11

keep viewdata on RedirectToAction

6 Answers6

Linked