1

I have a serious problem about a method. So this is my method : 

Object.prototype.clonage = function() {
  var newObj = (this instanceof Array) ? [] : {};
  for (i in this) {
    if (i == 'clone') continue;
    if (this[i] && typeof this[i] == "object") {
      newObj[i] = this[i].clonage();
    } else newObj[i] = this[i]
  } return newObj;
}

And the browser is giving me:

Uncaught RangeError: Maximum call stack size exceeded

At the line:

for (i in this) {

Can someone has the same problem?

Florent
  • 12,310
  • 10
  • 49
  • 58
Simon
  • 1,191
  • 1
  • 18
  • 38
  • You're probably calling `.clonage` infinitely or just really really often. – Halcyon Sep 07 '12 at 13:32
  • Frits is probably right. Can you give us some context as to how you're calling it? I just tested it on a single clonage call and it worked fine. – Clay Garrett Sep 07 '12 at 13:36
  • I'm using it like that : window.tweetOrberByPassed = window.displayedTweetListing.clonage(); both of them are object. I have the same function in another script page and I have no problem about it. – Simon Sep 07 '12 at 13:39

1 Answers1

1

I can make javascript objects that can break your clonage function if that is an achievement of any kind :).

check: http://jsfiddle.net/Bd6XL/2/

var x = { 
    a: 5, 
    b: "asdf" 
};
var y = { 
    a: 5, 
    b: "asdf" 
};

x.y = y;
y.x = x;

Clone any of them. Yes it wont work because of circular references. Try to debug your object and see if there is any circular reference.

Also try limit your clone to what you really need.

EDIT:

Check out this question about cloning: What is the most efficient way to deep clone an object in JavaScript?

There are quite a few answers. Try the accepted one if you use jQuery:

// Shallow copy
var newObject = jQuery.extend({}, oldObject);

// Deep copy
var newObject = jQuery.extend(true, {}, oldObject);
Community
  • 1
  • 1
vinczemarton
  • 7,756
  • 6
  • 54
  • 86