Delete selected row from table in php

Question

I am using the code (pasted below) to delete the record from the table when it's selected by the checkbox. It is working, but it is not deleting the record from the table, it is only showing the echo "Records deleted Successfully.".

Please have a look at my code and suggest me some changes.

<?php
echo "Hiiiiiiiiii";
include("conn.php");
$sql="select * from test ";

$res=mysql_query($sql) or die(mysql_error());
?>

<form name="form1" method="POST" action="">
    <table width="578" border="1" align="center" id="menu">
    <tr>
    <th></th>
    <th>id</th>
    <th>Name</th>
    <th>email</th>
    <th>phno</th>
 </tr>

<?php
 while($row=mysql_fetch_array($res))
 {
?>

 <tr>

    <td><input name="checkbox[]" type="checkbox" id="checkbox[]" value="<? echo $rows['id']; ?>"></td>
    <td><?php echo $row['id'];?></td>

    <td><?php echo $row['name'];?></td>
    <td><?php echo $row['emailid'];?></td>

    <td><?php echo $row['phno'];?></td>
    <?php
    echo"<td><a href='update.php?id=".$row['id']."'>Update</a></td>";
    ?>
 <?php
  }
 ?>  
 <tr><td><input type="submit" name="delete" value="Delete" id="delete"></td></tr></tr></table>

 <?php
// Check if delete button active, start this
$count = mysql_num_rows($res);
echo "$count";

if(isset($_POST['delete']))
    {
         $delete_id = $_POST['checkbox'];
         $id = count($delete_id );
         if (count($id) > 0)
          {
             foreach ($delete_id as $id_d)
             {
                $sql = "DELETE FROM `test` WHERE id='$id_d'";
                $delete = mysql_query($sql);
            }
        }
        if($delete)
        {
            echo $id." Records deleted Successfully.";
        }
    }
>?

I have already answered you for for the same first question. — Mihai Iorga, Sep 19 '12 at 07:16
@Mihai Iorga: yes, i am new for php and previous code was difficult to me for to learn so i try this code its eassy but not working pls explain me — swapnil, Sep 19 '12 at 07:20
WHy not use the ID value you pass as ID.. ? (other than people could easily hack it which is another discussion) — BugFinder, Sep 19 '12 at 07:20
@gautam:if i select 2 checkbox it shows:Array ( [0] => [1] => ) 2 Records deleted Successfully. — swapnil, Sep 19 '12 at 07:22
Oh the array is null that means it not passing the id's,have you noticed it..?? — GautamD31, Sep 19 '12 at 07:23

score 2 · Answer 1 · answered Sep 19 '12 at 07:25

Add error_reporting(E_ALL); to the top of your file. Now you will be able to see all errors. http://php.net/manual/en/function.error-reporting.php

Also, use var_dump() to check what is actually in your variables. When you run var_dump($_POST); you can clearly see what is actually in your post. http://php.net/manual/en/function.var-dump.php

score 1 · Answer 2 · answered Sep 19 '12 at 07:19

if(isset($_POST['delete'])){
    $delete = false;
    $ids = array();
    foreach($_POST['checkbox'] as $val){
        $ids[] = (int) $val;
    }
    $ids = implode("','", $ids);
    $sql = "DELETE FROM `test` WHERE id IN ('".$ids."')";
    $delete = mysql_query($sql);
    $id = mysql_affected_rows();
    if($delete){
        echo $id." Records deleted Successfully.";
    }
}

also your check-boxes should have:

<input name="checkbox[]" type="checkbox" id="checkbox[]" value="<?php echo $row['id']; ?>">

score 1 · Answer 3 · answered Sep 19 '12 at 07:22

Put the delete code before selecting the records, then only you can see the actual records available in the DB.

    <?php
    echo "Hiiiiiiiiii";
    include("conn.php");

    if(isset($_POST['delete']))
        {
             $delete_id = $_POST['checkbox'];
             $id = count($delete_id );
             if (count($id) > 0)
              {
                 foreach ($delete_id as $id_d)
                 {
                    $sql = "DELETE FROM `test` WHERE id='$id_d'";
                    $delete = mysql_query($sql);
                }
            }
            if($delete)
            {
                echo $id." Records deleted Successfully.";
            }
        }


    $sql="select * from test ";

    $res=mysql_query($sql) or die(mysql_error());
    ?>
    <form name="form1" method="POST" action="">
        <table width="578" border="1" align="center" id="menu">
        <tr>
        <th></th>
        <th>id</th>
        <th>Name</th>
        <th>email</th>
        <th>phno</th>
     </tr>

<?php
 while($row=mysql_fetch_array($res))
 {
?>

 <tr>

    <td><input name="checkbox[]" type="checkbox" id="checkbox[]" value="<? echo $rows['id']; ?>"></td>
    <td><?php echo $row['id'];?></td>

    <td><?php echo $row['name'];?></td>
    <td><?php echo $row['emailid'];?></td>

    <td><?php echo $row['phno'];?></td>
    <?php
    echo"<td><a href='update.php?id=".$row['id']."'>Update</a></td>";
    ?>
 <?php
  }
 ?> 
 <tr><td><input type="submit" name="delete" value="Delete" id="delete"></td></tr></tr></table>

 <?php
// Check if delete button active, start this
$count = mysql_num_rows($res);
echo "$count";
>?

score 0 · Answer 4 · edited May 23 '17 at 12:21

0

There is a Typo in the code that outputs the id:

... value="<? echo $rows['id']; ?>">

It should be

... value="<? echo $row['id']; ?>">

Note that your code is also vulnerable to SQL-injection attacks. You should check if the ids in the POST-request are really integers.

edited May 23 '17 at 12:21

Community

1
1

answered Sep 19 '12 at 07:19

Sven Koschnicke

6,523
2
34
49

Also, check Jelmers answer how to avoid such issues. http://stackoverflow.com/a/12490215/390808 – Sven Koschnicke Sep 19 '12 at 07:36

score 0 · Accepted Answer · answered Sep 19 '12 at 07:20

0

<? echo $rows['id']; ?>

there is no $rows here remove the s put

<? echo $row['id']; ?>

answered Sep 19 '12 at 07:20

Ghassan Elias

2,213
1
14
17

score 0 · Answer 6 · answered Sep 19 '12 at 07:21

You should name the checkboxes something like

name="checkbox[<?php echo $row['id'] ?>]"

And then when you're trying to delete

foreach ($_POST['checkbox'] as $id => $delete) {
    // delete id
}

Your way of selecting an id by count is rather awkward, you're also only deleting 1 row, which is apparently non-existant because the count is not an id. Also, the value of a checkbox is meant to be an indicator off the checkbox being ticked or not, it's not usually holding a value, the usual way is to make the name hold what the checkbox actually means.

tanks to all for explaining me. – swapnil Sep 19 '12 at 07:28 — swapnil, Sep 19 '12 at 07:28

score 0 · Answer 7 · edited Sep 19 '12 at 10:20

0

you should move this code below of include("conn.php"); in your code

if (isset($_POST['delete'])) {
    $delete_id = $_POST['checkbox'];
    $id        = count($delete_id);
    if (count($id) > 0) {
        foreach ($delete_id as $id_d) {
            $sql    = "DELETE FROM `test` WHERE id='$id_d'";
            $delete = mysql_query($sql);
        }
    }
    if ($delete) {
        echo $id . " Records deleted Successfully.";
    }
}

edited Sep 19 '12 at 10:20

hakre

193,403
52
435
836

answered Sep 19 '12 at 07:55

Afshin

4,197
3
25
34

@afshim: Please make yourself comfortable with the formatting tools we have on this website. For example, I edited your answer to show that there is a formatting for muli-linie code fragments, too. I hope this helps you a bit. – hakre Sep 19 '12 at 10:21

score 0 · Answer 8 · edited Aug 06 '13 at 16:47

0

<td><input name="checkbox[]" type="checkbox" id="checkbox[]" value="<? echo $rows['id'];?>"></td>
<td><?php echo $row['id'];?></td>

Need to change as below to work it perfectly:

<td><input name="checkbox[]" type="checkbox" id="checkbox[]" value="**<?php** echo $rows['id']; ?>"></td>

edited Aug 06 '13 at 16:47

Nunser

4,512
8
25
37

answered Aug 06 '13 at 16:21

Hardik Desai

1

Delete selected row from table in php

8 Answers8

Linked