Why my Replace isn't working as expected

Question

Possible Duplicate:
Fastest method to replace all instances of a character in a string

I have this

<p id="demo">/,\,:,*,?,",<,>,|</p>
<input type="button" onclick="myFunction()" value="Replace"/>

function myFunction() {
    var str = document.getElementById("demo").innerHTML;
    var n = str.replace(",", ", ");
    document.getElementById("demo").innerHTML = n;
}

What I want is to replace this "/,\,:,*,?,",<,>,|" with this "/, \, :, *, ?, ", <, >, |" but what I get is this "/, \,:,*,?,",<,>,|".

What am I doing wrong ??

You find answer here: http://stackoverflow.com/questions/6064956/replace-all-occurrences-in-a-string — Baptiste Pernet, Oct 04 '12 at 08:28
Or here: http://stackoverflow.com/questions/2116558/fastest-method-to-replace-all-instances-of-a-character-in-a-string -- So obviously a duplicate amoung lots of other topics about the same problem. — w00, Oct 04 '12 at 08:31

score 2 · Accepted Answer · answered Oct 04 '12 at 08:30

2

You'll have to use a regex to replace the string globally:

var n = str.replace(/,/g, ', ');

answered Oct 04 '12 at 08:30

Blender

289,723
53
439
496

score 1 · Answer 2 · answered Oct 04 '12 at 08:30

1

Replace this line var n = str.replace(",", ", ");

with

var n = str.replace(/,/g, ", ");

Default it only will replace the first occurens

answered Oct 04 '12 at 08:30

Simon Edström

6,461
7
32
52

score 0 · Answer 3 · edited May 23 '17 at 11:47

0

The replace in javascript replaces only the first occurrence.

You need do use either regex, or a loop.

Check this out : Javascript multiple replace

edited May 23 '17 at 11:47

Community

1
1

answered Oct 04 '12 at 08:30

arpad

541
5
10

Why my Replace isn't working as expected

3 Answers3