File upload with ServletFileUpload's parseRequest?

Question

I upload the file which I browse with input type="file" in my web App. The issue is I get the FileItem list size as 0 though I can see all uploaded file info under

request -> JakartaMutltiPartRequest -> files attribute

Here is java code that reads the file

public InputStream parseRequestStreamWithApache(HttpServletRequest request)
  throws FileUploadException, IOException {
  InputStream is = null;
  FileItemFactory factory = new DiskFileItemFactory();
  ServletFileUpload upload = new ServletFileUpload(factory);
  List items = upload.parseRequest(request);
  // here the item size is 0 ,i am not sure why i am not getting my file upload in browser with type="file"
  // but If inspect request in debugger i can see my file realted info in request--->JakartaMutltiPartRequest----->files attribute
  Iterator iter = items.iterator();
  while (iter.hasNext()) {
    FileItem item = (FileItem) iter.next();

    if (!item.isFormField()) {
      is = item.getInputStream();
    }
  }

  return is;
}

EDIT:

Here is JSP part:

<form NAME="form1" action="customer/customerManager!parseRequestStreamWithApache.action" ENCTYPE="multipart/form-data"   method="post" >
     <TABLE >
         <tr>
              <th>Upload File</th>
                  <td>
                   <input name="fileUploadAttr" id="filePath"  type="file" value="">
                 </td>
                  <td > 
                 <Input type="submit" value ="uploadFile"/>
                  </td>
          </tr>
    </TABLE>
</form>

Uploading to struts 2 action? – Roman C Oct 25 '12 at 11:39 — Roman C, Oct 25 '12 at 11:39

score 14 · Accepted Answer · edited May 18 '16 at 22:11

14

As I said in a comment to the same question, you posted earlier, this is most likely because you have parsed the request already before. The files are part of the request body and you can parse it only one time.

Update:

I usually do use commons-upload in that way:

if (ServletFileUpload.isMultipartContent(request)) {
    ServletFileUpload fileUpload = new ServletFileUpload();
    FileItemIterator items = fileUpload.getItemIterator(request);
    // iterate items
    while (items.hasNext()) {
        FileItemStream item = items.next();
        if (!item.isFormField()) {
            is = item.openStream();
        }
    }
}

edited May 18 '16 at 22:11

slim

2,545
1
24
38

answered Oct 24 '12 at 12:16

Udo Klimaschewski

5,150
1
28
41

But i did not the parse the request earlier – M Sach Oct 24 '12 at 12:19
Can you show the rest of your servlet code that does anything with your HttpServletRequest before parseRequestStreamWithApache() is called? – Udo Klimaschewski Oct 24 '12 at 12:31
I placed the code in very first filter of my webapp, still the same result.So looks like that is not the issue – M Sach Oct 24 '12 at 12:54
I updated my answer with some code that does it a bit different, maybe you can give it a try? Allways worked for me. – Udo Klimaschewski Oct 24 '12 at 13:25
Thanks Udo. You was right. looks like struts2 fileupload plugin is already reading in between. – M Sach Oct 26 '12 at 10:57

Roman C · Answer 2 · 2014-04-07T13:29:21.913

You should check for multipart content

boolean isMultipart = ServletFileUpload.isMultipartContent(request);

if (isMultipart) {
    FileItemFactory factory = new DiskFileItemFactory();
    ServletFileUpload upload = new ServletFileUpload(factory);

    try {
        List items = upload.parseRequest(request);
        Iterator iterator = items.iterator();
        while (iterator.hasNext()) {
            FileItem item = (FileItem) iterator.next();
            if (!item.isFormField()) {
                String fileName = item.getName();

                String root = getServletContext().getRealPath("/");
                File path = new File(root + "/fileuploads");
                if (!path.exists()) {
                    boolean status = path.mkdirs();
                }

                File uploadedFile = new File(path + "/" + fileName);
                item.write(uploadedFile);
            }
        }
    } catch (Exception e) {

@MSach it seems that action url have collisions with struts filter. If you are using struts why don't you use its fileupload feature? Post web.xml and remove everything except servlet configuration. — Roman C, Oct 24 '12 at 16:51

score 0 · Answer 3 · answered Oct 24 '12 at 12:18

0

How big are the files you are uploading? You might be over the default threshold. I think the default is 10K

factory.setSizeThreshold(maxSizeYouWantToHandle);

answered Oct 24 '12 at 12:18

mprivat

21,582
4
54
64

The threshold sets the limit up what size the data will be kept in memory, if the threshold (10K default is correct) is passed, the data will be stored on disk. In java.io.tempdir by default. – Udo Klimaschewski Oct 24 '12 at 12:26

score 0 · Answer 4 · answered Nov 14 '14 at 18:13

0

If you are using weblogic 12 then check whether the patch_wls1211 is insatlled or not. I was having the same issue and it resolved after applying patch_wls1211.

answered Nov 14 '14 at 18:13

Prasanth

35
4

File upload with ServletFileUpload's parseRequest?

4 Answers4

Linked