resizing from paintComponent method

Question

I have this little code

public class Test extends JFrame {

public static void main(String[] args) {
    new Test();
}

Test() {
    getContentPane().add(new MyPanel());

    pack();
    setVisible(true);
}

private class MyPanel extends JPanel {

    @Override
    protected void paintComponent(Graphics g) {
        setSize(640, 480);
        setPreferredSize(new Dimension(640, 480));
        setMinimumSize(new Dimension(640, 480));
        g.fillRect(20, 20, 50, 50);
    }

}

Unfortunately the frame is not resized to the size of the nested panel after calling pack(). I already read the related answers for this topic, but none of them helped. Could you provide me a solution, please?

Attempting to change the state of the GUI within `paintComponent(Graphics)` will lead to trouble. Don't do it. — Andrew Thompson, Nov 07 '12 at 22:06

score 4 · Accepted Answer · edited May 23 '17 at 12:27

When pack() is executed the panel is still invisible and its paintComponent() was not executed and as a result setPreferredSize() wasnt executed as well.

But don't call setPreferredSize from paintComponent(). Do your painting in paintComponent nothing else. Avoid putting program logic into that method. Painting operations should be fast and optimized for better performance and user experience. See Performing Custom Painting for more details.

Override panel's getPrefferedSize(), or at least execute setPrefferedSize before pack().

Also see Should I avoid the use of set[Preferred|Maximum|Minimum]Size methods in Java Swing.

score 2 · Answer 2 · answered Nov 07 '12 at 21:59

2

    public MyPanel() {
        setPreferredSize(new Dimension(640, 480));
    }

answered Nov 07 '12 at 21:59

martinez314

12,162
5
36
63

-1 for setPreferredSize without need (note: there's extremely rare contexts where such a need might exist :-) – kleopatra Nov 08 '12 at 09:11

resizing from paintComponent method

2 Answers2