What wrong with my cout?

Question

In C++, Ubunt 12.04, I have a file named config.txt which contains user name and password. I have 2 public static string variables: USER and PASSWORD. This is my code:

// Read file from config
string text[2];
int count = 0;
while(!fin.eof()){
    getline(fin,text[count]);
    count++;
    if(count == 2){
        break;
    }
}
CONNECTOR::USER = text[0];
CONNECTOR::PASSWORD = text[1];

string userAndPassword =  CONNECTOR::USER + ":" + CONNECTOR::PASSWORD;
cout << CONNECTOR::USER << endl; // It's fine, right user: qsleader
cout << CONNECTOR::PASSWORD << endl; // ok, right password: 123456
cout <<"user and password: " <<  userAndPassword << endl; // It's weird text! Problem here!

The weird text result is: :123456d password: qsleader!! This is not what I expected! But I don't know why this happen? Can anyone give me an suggestion? (If i print: cout << "user and password: qsleader:123456", the result is good!!)!

Have a look at [this question](http://stackoverflow.com/questions/5605125/why-is-iostreameof-inside-a-loop-condition-considered-wrong). — juanchopanza, Nov 12 '12 at 09:09
Maybe your file contains leading whitespaces with the value `0x08`, which maps to backspace, and therefore kills part of your output — Chris, Nov 12 '12 at 09:10
Is this exactly the code you are compiling and running? Because this should work then. If you altered the code for posting it here, then chances are high, that the defect part is missing — Chris, Nov 12 '12 at 09:18

score 2 · Accepted Answer · answered Nov 12 '12 at 09:20

2

The problem is created when you read the values. Indeed, I guess that your file has the two items on two different lines. Furthermore, I guess this file uses Windows line endings. Therefore, when you read the first item, it reads qsleader\r and then stops as the next extracted character is \n, extracted but not appended to the string.

When you create the userAndPassword string, it is in fact qsleader\r:123456. This special character \r is a return carriage. It makes the cursor go to the beginning of the line. Therefore, on the last line, you first output user and password: qsleader, then go back to the first column, and write :123456, resulting in :123456d password: qsleader.

answered Nov 12 '12 at 09:20

Didier Trosset

36,376
13
83
122

Excellent answer...haven't thought of windows line endings – Chris Nov 12 '12 at 09:21
@Chris File name is `config.txt`. The extension is a clue. – Didier Trosset Nov 12 '12 at 09:26
Nice work! How I can express my great thank to you!! Thanks you very much! I port my work from `windows` to `Ubuntu` and this the problem! – Kingfisher Phuoc Nov 12 '12 at 09:30

score 0 · Answer 2 · answered Nov 12 '12 at 09:11

0

You are setting userAndPassword to a hellish expression involving assignments. I guess your intent was:

string userAndPassword = CONNECTOR::USER + ":" + CONNECTOR::PASSWORD

answered Nov 12 '12 at 09:11

Angew is no longer proud of SO

167,307
17
350
455

What wrong with my cout?

2 Answers2