Java if else statement changing string

Question

Possible Duplicate:
How do I compare strings in Java?

I have the following code but for some reason it won't change the string

The accountClass returns the string "L"

String accountClass = accClass.substring(4, 5);
        if (accountClass == "A") {
            accountClass = "Staff - A";
        } else if (accountClass == "B") {
            accountClass = "Student - B";
        } else if (accountClass == "H") {
            accountClass = "Personal - H";
        } else if (accountClass == "K") {
            accountClass = "60 Plus - K";
        } else if (accountClass == "L") {
            accountClass = "Business - L";
        } else if (accountClass == "P") {
            accountClass = "Charity - P";
        } else if (accountClass == "Q") {
            accountClass = "AIB Subsidiary - Q";
        } else if (accountClass == "X") {
            accountClass = "Irish State Spons & Sub's - X";
        } else if (accountClass == "Y") {
            accountClass = "Other Companies & Orgs - Y";
        } else if (accountClass == "Z") {
            accountClass = "Impersonal & Gen. Ledger - Z";
        }

I'm just wondering if its the == causing the problem or something else?

Yes, it is causing the problem. – Marko Topolnik Dec 21 '12 at 11:25 — Marko Topolnik, Dec 21 '12 at 11:25

score 2 · Accepted Answer · answered Dec 21 '12 at 11:25

Always check string equality with equals() method. In case of Objects == checks if two reference variables refer to the same instance. to check if two strings are meaningfully equal use String.equals() method.

if (accountClass == "A") {

should be

if (accountClass.equals("A")) {

and so does your other if statements.

score -1 · Answer 2 · answered Dec 21 '12 at 11:26

-1

just realised it should be if (accountClass.equals("L"))

answered Dec 21 '12 at 11:26

topcat3

2,561
6
33
57

please upvote and accept the other answer that already told you this. – Alnitak Dec 21 '12 at 11:28
@Alnitak Actually, should read one of many thousands of the same answers to the same question. – Marko Topolnik Dec 21 '12 at 11:32
@MarkoTopolnik that too, including the one I wrote that has a hundred+ upvotes ;-) – Alnitak Dec 21 '12 at 11:35
1

thanks. yep srry I had googled but I was under time constraints. appreciated all help – topcat3 Dec 21 '12 at 12:04
@topcat3 if you are in a Java class, this should have been in one of the first sessions... I blame the teacher! ;-) – PhiLho Dec 21 '12 at 12:54
@PhiLho it probably was lol but sometimes you forget the easy bits when its staring you right in your face – topcat3 Dec 21 '12 at 12:57

Java if else statement changing string

2 Answers2