removeChild() : how to remove indent too?

Question

Let's consider the following XML document:

<items>
   <item>item1</item>
   <item>item2</item>
</items>

Now, let's remove all the items and add some new item. Code:

  //-- assume we have Element instance of <items> element: items_parent
  //   and the Document instance: doc

  //-- remove all the items
  NodeList items = items_parent.getElementsByTagName("item");

  for (int i = 0; i < items.getLength(); i++){
     Element curElement = (Element)items.item(i);
     items_parent.removeChild(curElement);
  }

  //-- add a new one
  Element new_item = doc.createElement("item");
  new_item.setTextContent("item3");
  items_parent.appendChild(new_item);

New contents of the file:

<items>


   <item>item3</item>
</items>

These annoying blank lines appeared because removeChild() removes child, but it leaves indent of removed child, and line break too. And this indent_and_like_break is treated as a text content, which is left in the document.

In the related question I posted workaround:

items_parent.setTextContent("");

It removes these blank lines. But this is some kink of hack, it removes the effect, not the cause.

So, the question is about removing the cause: how to remove child with its intent with line break?

Check [this](http://stackoverflow.com/questions/978810/how-to-strip-whitespace-only-text-nodes-from-a-dom-before-serialization) — MadProgrammer, Jan 10 '13 at 10:01
Thank you, this solved the issue for me. You can add this like an answer, and I'll accept it. Or, the question is not actually correct, so, maybe flag it as a duplicate or even delete, not sure.. — Dmitry Frank, Jan 10 '13 at 10:17
@MadProgrammer, I already upvoted both question and answer without your mentioning, of course. — Dmitry Frank, Jan 10 '13 at 10:31

T.J. Crowder · Accepted Answer · 2013-11-12T17:36:04.357

15

The "indent" before the element and the "carriage return" (and following indent) after it are text nodes. If you remove an element and there's a text node before or after it, naturally those nodes are not removed.

It sounds as though you want to remove the element, and then also remove the text node in front of it (provided it consists entirely of whitespace).

E.g., perhaps along these lines (in your loop removing items):

 Element curElement = (Element)items.item(i);
 // Start new code
 Node prev = curElement.getPreviousSibling();
 if (prev != null && 
     prev.getNodeType() == Node.TEXT_NODE &&
     prev.getNodeValue().trim().length() == 0) {
     items_parent.removeChild(prev);
 }
 // End new code
 items_parent.removeChild(curElement);

However, the real question should probably be why your XML document has extraneous whitespace text nodes in it.

edited Nov 12 '13 at 17:36

answered Jan 10 '13 at 10:01

T.J. Crowder

1,031,962
187
1,923
1,875

Thanks, your solution works for real removing indent before element! Ohh, I'm confused: you gave me exact answer on my question, but now I understand that this (my) approach seems to be hacky.. My bad. Sorry. Not sure what answer I should accept :) – Dmitry Frank Jan 10 '13 at 10:48
1

prev.getNodeValue().trim() is a String so prev.getNodeValue().trim().length should be changed to prev.getNodeValue().trim().length(). Otherwise, great answer- helped me a lot. +1 – Tom G Nov 12 '13 at 17:34

score 1 · Answer 2 · answered Jan 10 '13 at 09:59

1

Actually an XML document does not have to follow any style guidelines. Therefore you cannot except document manipulation methods to keep some kind of style to your document.

What I'd recommend is generally manipulating your file first without any respect to the format (just get a valid xml file then) and afterwards you can always run a formatter over the whole document to get your desired formatting.

answered Jan 10 '13 at 09:59

s1lence

2,188
2
16
34

Yes, you're right. MadProgrammer's link solved the trouble for me, and your approach is correct. – Dmitry Frank Jan 10 '13 at 10:18

removeChild() : how to remove indent too?

2 Answers2