should I be using an @html.renderpartial or @html.renderaction

Question

I'm trying to bring in my menu.

In my _Layout.cshtml page I have

<div class="wrapper">
                <!-- Navigation -->

                  @Html.RenderAction("Navigation", "Nav")

The Nav Controller looks like this

public ActionResult Navigation()
{
    var pages = pageRepository.Pages;
    return View(pages);
}

The Navigation View Looks like this

@model IEnumerable<Site.Domain.Entities.Page>
@{
    Layout = null;
    List<Site.Domain.Entities.Page> pages = new List<Site.Domain.Entities.Page>();

    foreach(var page in Model)
    {
        pages.Add(page);
    }
}

@foreach (var link in Model)
{
    if (link.ParentPage == "Home")
    { 
    <li>@link.PageTitle</li>
    <ul>
        @foreach (var subLink in pages)
        {
            if (subLink.ParentPage == link.PageTitle)
            { 
            <li>@subLink.PageTitle</li>
            }
        }
    </ul> 

    }
}

The view works fine when I go to .../nav/navigation

What I'm trying to do is bring this into my _Layout page so that I can use it as my menu.

I continue to get an error with @Html.RenderAction("Navigation", "Nav")

The error says "The best overloaded method match for 'System.Web.WebPages.WebPageExecutingBase.Write(System.Web.WebPages.HelperResult)' has some invalid arguments"

Should I be using this as a partial? What is the best way to go about this? Thanks for any advice!

Use the debugger to find what is happening. – leppie Jan 25 '13 at 17:02 — leppie, Jan 25 '13 at 17:02

score 12 · Accepted Answer · edited Oct 04 '15 at 16:53

12

For what you're trying to do, @Html.RenderAction(..) is the correct call. RenderAction is ChildActionExtension and will need to add that attribute to the controller.

Your controller should look something like below. Note that you will want to return a PartialView as well.

[ChildActionOnly]
public ActionResult Navigation()
{
    var pages = pageRepository.Pages;
    return PartialView(pages);
}

The Render action does not return HTML, but rather adds the content to the response. With that, your view should look like:

@{@Html.RenderAction("Navigation", "Nav");}

Reference: http://msdn.microsoft.com/en-us/library/ee721274(v=vs.108).aspx

edited Oct 04 '15 at 16:53

pb2q

58,613
19
146
147

answered Jan 25 '13 at 17:03

anAgent

2,550
24
34

Please do not use secon @ in MVC5 . Correct Syntax: @{Html.RenderAction("Navigation", "Nav");} – Karl Jan 24 '18 at 19:51
@{Html.RenderAction("Navigation");} syntax to render the action – PAWAN RAJ Shakya Apr 23 '18 at 18:04

David L · Answer 2 · 2016-04-13T15:26:23.700

3

Because Html.RenderAction is a void and does not return a value, you need to "escape" the call with braces

@{Html.RenderAction("Navigation", "Nav");}

In your controller, you should return a partial view instead.

public ActionResult Navigation()
{
    var pages = pageRepository.Pages;
    return PartialView(pages);
}

edited Apr 13 '16 at 15:26

answered Jan 25 '13 at 17:06

David L

32,885
8
62
93

Just use @Html.Action("Navigation","Nav") in MVC5 – Karl Jan 24 '18 at 19:53

should I be using an @html.renderpartial or @html.renderaction

2 Answers2