JavaScript variable on HTML

Question

I'm trying to use the value of a JavaScript variable; however, for some reason, document.write is not working.

Can you tell me what am I doing wrong and if there's another way to do this? Here is my JavaScript code:

<script type="text/javascript">
    var url=${paramValue};
    url = url.replace(/\s/g,"%20");
    document.write("<a href='" + url + "'>" +
        "<img src='/folder1/folder2/folder3/folder4/folder5/image.png'" +
        " width='70' height='20'></a>");
</script>

The variable url=${paramValue}; is working, as I can check it with firebug. The image is not appearing.

What do you get if you do this: var url=${paramValue}; alert(url); — isherwood, Feb 08 '13 at 17:15

score 2 · Answer 1 · edited May 23 '17 at 11:44

2

What is parsing your url variable? "${paramValue}" is not going to be interpreted by the JS interpreter.

Don't bother manually decoding/encoding URLs in Javascript...just use the built in:

encodeURIComponent(str) encodeURI(str)

Encode URL in JavaScript?

edited May 23 '17 at 11:44

Community

1
1

answered Feb 08 '13 at 17:17

HankHendrix

295
2
9

score 0 · Answer 2 · answered Feb 08 '13 at 17:18

0

I think you need quotes around your parameter, so the javascript interprets it as a string after the replacement:

var url='${paramValue}';

But I agree with Hank - use the built in functions.

answered Feb 08 '13 at 17:18

Mike C

3,077
22
29

score -1 · Answer 3 · answered Feb 08 '13 at 17:24

<html> 
<head>
<script type="text/javascript"> 
function myfunction(){
    var url = $("#<%=url.ClientID %>").val();
    document.write("<a href='" + url + "'><img src='abc.jpg' width='70'height='20'>    
    </a>");
}
</script>
</head>
<body>
<form runat="server">
   <asp:TextBox ID="url" runat="server" />
   <input type="button" value="Clear" onclick="myfunction()" />
</form>
</body>  
</html>

JavaScript variable on HTML

3 Answers3