errors in code noob cant fix them

Question

I am working on a small application that displays data from a database table. I am getting 2 errors and dont know why are there, and I cant figure it out as I am still a noob. I guess its something stupid, please help.

ERRORS

A PHP Error was encountered

Severity: Notice

Message: Undefined variable: querys


Severity: Warning

Message: Invalid argument supplied for foreach()

these errors are located in my view page.

VIEW

    <?php foreach ($queries as $row): ?>
    <table>

       <th>Name</th>
       <th>Surname</th>
       <th>phone</th>
       <th>email</th>

       <td><?php echo $row->name; ?></td>
       <td><?php echo $row->surname; ?></td>
       <td><?php echo $row->phone; ?></td>
       <td><?php echo $row->email; ?></td>

   </table>  
    <?php endforeach; ?>

CONTROLLER

  function display($offset = 0)
    {
           $limit = 20;
            $this->load->model('info_model');

            $results = $this->info_model->search($limit, $offset);

            $data['queries'] = $results['rows'];
            $data['num_results'] = $results['num_rows'];


            $this->load->view('info_view',$data);


    }

MODEL

 function search ($limit, $offset){

          //results query 
          $q = $this->db->select('ID, name, surname, phone, email');
          $this->db->from('tblinfo');
          $this->db->limit($limit, $offset);

          $ret['rows'] = $q->get()->result();
          //count query
          $q = $this->db->select('COUNT(*) as count', FALSE )
          ->from('tblinfo');

          $tmp = $q->get()->result();

          $ret['num_rows'] = $tmp[0]->count;
          return $ret;
      }

EDIT

i fixed the foreach error by inserting

   <?php if(is_array($queries)): ?>
   <?php endif; ?>

the only error i am getting is the

   A PHP Error was encountered

    Severity: Notice

    Message: Undefined variable: queries

if this is the begining of the code then its obvious error. there must be some code written on top of it. where is it? — dejjub-AIS, Mar 13 '13 at 07:42
The following might be helpful for you: [Reference - What does this error mean in PHP?](http://stackoverflow.com/q/12769982/367456) — hakre, Mar 13 '13 at 07:43
`$data['query'] = $results['rows'];` but instead of using `query` in the view, you use `querys`. Probably not the only error, but seems like a typo. — Joachim Isaksson, Mar 13 '13 at 07:46
no i tryed to change querys to query i am getting the same two errors — user2143150, Mar 13 '13 at 07:48
Is your results being passed properly? $data['query'] = $results['rows']; I am not sure if you are actually getting the array passed over to the view. Prior to doing the foreach ($query as $row) I would add if (is_array($query)) { foreach ($query as $row) {...}} — Robert Lee, Mar 13 '13 at 07:54
Not sure why this is being downvoted? The OP asks a very easy to understand question, and provides all the code needed to solve it?? — Jeemusu, Mar 13 '13 at 08:02
i did try that but it not change anything same 2 errors are showing up — user2143150, Mar 13 '13 at 08:03
I would focus on the query and returning the data from the model -> controller and just edit your $query variable typo. — Robert Lee, Mar 13 '13 at 08:06

score 5 · Answer 1 · edited Mar 13 '13 at 08:36

5

$data['query'] = $results['rows'];

should be

$data['querys'] = $results['rows']; // although correct spelling is "queries"

Then you can access $querys inside your view.

edited Mar 13 '13 at 08:36

Mischa

42,876
8
99
111

answered Mar 13 '13 at 07:57

Damien Pirsy

25,319
8
70
77

that dose not work i already triad that but tnx for answering – user2143150 Mar 13 '13 at 08:02
@user2143150 This is the answer to why you were getting an error saying that `$querys` was not defined. If it's not working, tell us why? Is there a new error message? It could be possible, that your database query doesn't return any results? – Jeemusu Mar 13 '13 at 08:03
no the error messages do not change they are the same as in above question – user2143150 Mar 13 '13 at 08:05
i did try this before posting this question – user2143150 Mar 13 '13 at 08:06
This is one of the problems with your code above. The other, is most likely that your model isn't getting any data. – Jeemusu Mar 13 '13 at 08:07
I think he shouldn't be returning two values via an array workaround, but this is indeed the main problem. – Mischa Mar 13 '13 at 08:42
in my code i forgot to include i have a form_open(); if that makes any difference ? – user2143150 Mar 13 '13 at 08:57

score 1 · Answer 2 · answered Mar 13 '13 at 08:17

The problem seems to be with your models search() method, which is probably not returning any results. I would re-write it as follows to utilize codeigniters active record class:

function search ($limit, $offset){

    //results query 
    $this->db->select('ID, name, surname, phone, email');
    $q =  $this->db->get('tblinfo', $limit, $offset);

    $ret['rows'] = $q->result();

    //count query
    $ret['num_rows'] = $this->db->count_all('tblinfo');

    return $ret;
}

You can use Codeigniters active record class to get a count of all records in a specific table using just $this->db->count_all('table_name');

I would fix typo ret['rows'] to $ret['rows'] – Robert Lee Mar 13 '13 at 08:20 — Robert Lee, Mar 13 '13 at 08:20

Robert Lee · Answer 3 · 2013-03-13T08:22:36.597

0

Maybe change your search code a little

$q = $this->db->select('ID, name, surname, phone, email')
              ->from('tblinfo')
              ->limit($limit, $offset);

edited Mar 13 '13 at 08:22

answered Mar 13 '13 at 08:15

Robert Lee

1,541
1
10
20

Mischa · Accepted Answer · 2013-03-13T09:53:10.813

0

Personally I think a function should perform only one task. Right now you are trying to do two tasks (return records and return a record count) in one function.

I would rewrite my model like this:

function search($limit, $offset)
{
  $this->db->select('ID, name, surname, phone, email');
  $this->db->from('tblinfo');
  $this->db->limit($limit, $offset);
  return $this->db->get();
}

And your controller could look like this:

function display($offset = 0)
{
  $this->load->model('info_model');
  $results = $this->info_model->search(20, $offset);

  $data['queries'] = $results->result();
  $data['num_results'] = $this->db->count_all('tblinfo'); // Alternatively you could make a separate model function that does this

  $this->load->view('info_view', $data);
}

edited Mar 13 '13 at 09:53

answered Mar 13 '13 at 08:23

Mischa

42,876
8
99
111

tnx fore answering but its the same error when i tried Undefined variable: queries – user2143150 Mar 13 '13 at 08:27
@user2143150, could you try again with exactly the code above? This *should* work. – Mischa Mar 13 '13 at 08:30
its the same error tnx for the effort – user2143150 Mar 13 '13 at 08:33
@user2143150, sorry, I spotted one more mistake... I forgot `return` in the model. Please try again. – Mischa Mar 13 '13 at 08:34
same error again is there a simpler way maybe to retrieve records from table instead of my version of the code ? – user2143150 Mar 13 '13 at 08:38
@user2143150, what do you mean? I don't understand your question. – Mischa Mar 13 '13 at 08:40
all i am trying is to display the data that is on a table in a database. is there a simpler way of doing this instead of the code that i have ? – user2143150 Mar 13 '13 at 08:44
@user2143150, this is pretty basic already and it *should* work. Are you sure your `display` function gets called? Could you add the following to the top of your `display` function? `echo 'this is display'; exit;` and tell me what happens? – Mischa Mar 13 '13 at 08:47
@user2143150 - Glad to hear it! Just wondering... what was the problem? – Mischa Mar 13 '13 at 09:49
1

like u said the display function was not getting called that's why the unused variable there so i changed my code little bit and it worked. tnx for your help bdw – user2143150 Mar 13 '13 at 11:09

score 0 · Answer 5 · answered Mar 13 '13 at 08:34

Change your model code to this

function search ($limit, $offset){

      //results query 
      $this->db->select('ID, name, surname, phone, email');
      $this->db->from('tblinfo');
      $this->db->limit($limit, $offset);
      $q = $this->db->get();
      $ret['rows'] = $q->result();
      //count query
      $q1 = $this->db->select('COUNT(*) as count', FALSE )
      ->from('tblinfo');

      $tmp = $q1->get()->result();

      $ret['num_rows'] = $tmp[0]->count;
      return $ret;
  }

errors in code noob cant fix them

5 Answers5