10

I wrote a module in node.js that performs some network operation. I wrote a small script that uses this module (the variable check below). It looks like this:

check(obj, function (err, results) {
    // ...
    console.log("Check completed");
});

Now here is the interesting thing. When this code executes as part of a mocha test, the test exits as expected. I see the log statement printed and the process exits.

When the code is executed as a standalone node script, the log statement gets printed, but the process just hangs.

When I try to debug it and I start the program using --debug-brk and use node-inspector, it exits early! I see that process.on 'exit' is called. It exits while some internal callbacks within the module weren't called yet. So the log statement above isn't printed either.

I am stuck now and am not sure why this is happening. Has anyone seen similar behaviour?

Aishwar
  • 9,284
  • 10
  • 59
  • 80

2 Answers2

19

When you run it as a script and it hangs when "done", it means node still has callbacks registered waiting for events. Node doesn't know that those events won't fire anymore. You can either just call process.exit() if you know it's time to exit, or you can explicitly close/unbind/disconnect everything (network connections, db connections, etc). If you properly close everything, node should then exit.

The module wtfnode (mentioned by Nathan Arthur) or why-is-node-running can be really helpful tracking this down.

Peter Lyons
  • 142,938
  • 30
  • 279
  • 274
  • 5
    Is there someway to find out what is keeping node open? – Aishwar Apr 07 '13 at 04:19
  • 4
    If you have node-inspector and can attach to the process and set a break point in node's event loop code, maybe. I've never successfully tracked one of these down. It's either obvious things like opening a DB connection but never explicitly closing it, or I just do `process.exit()` and get on with my life. – Peter Lyons Apr 07 '13 at 04:28
  • 6
    process._getActiveHandles() and process._getActiveRequests() see http://stackoverflow.com/questions/17960452/how-can-i-get-a-list-of-callbacks-in-the-node-work-queue-or-why-wont-node-ex – aaron Apr 23 '15 at 23:09
  • Very useful tip! Saved me! – Sanandrea Jul 05 '16 at 21:10
  • 1
    why-is-node-running seems to have [multiple issues](https://github.com/mafintosh/why-is-node-running/issues) that prevent it from working on node 5 and/or with the request module. [wtfnode](https://github.com/myndzi/wtfnode) is working for me. – Nathan Arthur Sep 29 '16 at 16:05
0

If the program exits unexpectedly, it can be because the event loop becomes empty and there is nothing else to do (because some code forgot to emit an error or do something else to keep the event loop going). In this case Node exits with code 0 and you won't get any error messages whatsoever, so it can be really confusing.

See https://github.com/archiverjs/node-archiver/issues/457 for an example of this happening.

Andy
  • 7,885
  • 5
  • 55
  • 61