how to get buttonId was pressed in android

Question

I have a problem with the following piece of code:

OnClickListener button_listener = new View.OnClickListener()
        {
            @Override
            public void onClick(View v) {
                 ImageButton ibutton = (ImageButton) v; 
                 if(player == 0)
                 {

                     ibutton.setClickable(false);
                     ibutton.setImageResource(R.drawable.crossnew);
                     //Toast.makeText(getApplicationContext(),v.getText(), Toast.LENGTH_SHORT).show();
                     player = 1;
                 }

                 else if(player == 1)
                 {
                     ibutton.setClickable(false);
                     ibutton.setImageResource(R.drawable.zeronew);
                     player = 0;
                 }
            }

        };

how to get buttonId was pressed; help me please

when Toast.makeText(getApplicationContext(),v.getId(), Toast.LENGTH_SHORT).show(); was active, it become false — Vinra Gunanta Pandia, May 01 '13 at 07:30
Toast.makeText() is overloaded: 1) makeText(Context context, int resId, int duration) 2) makeText(Context context, CharSequence text, int duration) you accidentally used version 1), which takes a resource id as second parameter (and there is no String with the given id) please check my updated answer and for reference http://developer.android.com/reference/android/widget/Toast.html — Suau, May 01 '13 at 10:56

Suau · Accepted Answer · 2013-05-01T10:54:48.197

4

OnClickListener button_listener = new View.OnClickListener()
    {
        @Override
        public void onClick(View v) {
            Toast.makeText(getApplicationContext(), Integer.toString(v.getId()), Toast.LENGTH_SHORT)
            .show();
        }
    };

edited May 01 '13 at 10:54

answered May 01 '13 at 07:28

Suau

4,628
22
28

Well done sir! Was halfway through typing that out when I saw your answer :P – chris-tulip May 01 '13 at 08:06
updated the answer, @Pandia Vinra made a mistake with Toast.makeText(), v.getId() works fine – Suau May 01 '13 at 11:01

score 0 · Answer 2 · answered May 01 '13 at 07:27

0

if(v.getid() == R.id.testButton){
   Log.e("--->","click on testButton");
}

answered May 01 '13 at 07:27

Dhaval Parmar

18,812
8
82
177

score 0 · Answer 3 · edited May 23 '17 at 11:57

In your on click use a switch case.

@Override
public void onClick(View v) {
switch(v.getid()) // get id 
{
    case R.id.button1 :
         // button 1 clicked
      break;
    case R.id.button2 :
          // button 2 clicked
      break;   
} 
}

Edit:

In your comment displaying toast you are using application context.

Use a activity context in place of application context. Check the answer by commonsware

When to call activity context OR application context?

score 0 · Answer 4 · answered May 01 '13 at 07:58

0

In Button click function just use

        @Override
        public void onClick(View v) {

                        int id = v.getId();
           }

this will serve your purpose.

answered May 01 '13 at 07:58

Yatin Wadhawan

66
3

how to get buttonId was pressed in android

4 Answers4