If statement wont recognize string

Question

I have an if statement that takes a string, and if another string has the same value as that string do 1 thing, and if the variable doesnt equal that string do another thring

here is my code

if(Pos != "D"){
                System.out.println("doesnt = D");
            }

 if (Pos == "D" ){//WHY ISNT THIS WORKING
                System.out.println("it does = D");
                    }

It recognizes when the variable doesnt = D and prints "doesnt = d" but when the variable = D it does nothing. I dont know why.

thanks

it should..if the case is same – Adarsh May 31 '13 at 17:03 — Adarsh, May 31 '13 at 17:03

score 3 · Answer 1 · edited May 31 '13 at 17:03

3

Never compare Strings with == or != since these check to see if two String variables refer to the same object reference, and this is not what you're interested in. Instead use the equals(...) or equalsIgnoreCase(...) method to see if the two Strings have the same chars in the same order as that's what really matters here. i.e.,

Use equals to compare strings :

if ("D".equals(Pos))

edited May 31 '13 at 17:03

Hovercraft Full Of Eels

283,665
25
256
373

answered May 31 '13 at 17:00

Denys Séguret

372,613
87
782
758

@LuiggiMendoza Why not ? Do you think I should receive a lot of reputation for knowing that ? – Denys Séguret May 31 '13 at 17:01
No, just not get used to see this kind of answer very often. – Luiggi Mendoza May 31 '13 at 17:02
Fine, I'll throw my answer with yours and will delete mine. – Hovercraft Full Of Eels May 31 '13 at 17:03
@HovercraftFullOfEels I didn't ask for that – Denys Séguret May 31 '13 at 17:03
1

Minor exception: If both comparands are known to be interned you can compare with `==` and `!=`. – Hot Licks May 31 '13 at 17:04
@dystroy: is my information incorrect or misleading? If so, please delete or alter it. – Hovercraft Full Of Eels May 31 '13 at 17:05
@HotLicks Well, if you're sure. But that's not even an interesting optimization as String's equals does this test first. – Denys Séguret May 31 '13 at 17:05
@HovercraftFullOfEels Do you seriously suggest **you** might not know as much as me on this topic ? I was just saying I didn't want you to remove your answer. – Denys Séguret May 31 '13 at 17:06
@dystroy: yes, and why not. I'm no expert on Java, not by a long shot. – Hovercraft Full Of Eels May 31 '13 at 17:06
Well... you're 8k on java... I guess you know the basics... – Denys Séguret May 31 '13 at 17:07

If statement wont recognize string

1 Answers1