Calling the destructor from a different method of the same class

Asked Jun 03 '13 at 07:08

Active Jun 03 '13 at 07:14

Viewed 55 times

I have a problem

class Polygon 
{
    private:
        Vertex* vertices;
        int numVerts;
        static int RefCount;

    public:
        //Constructors
        Polygon(Vertex vert[], int numVerts){
            vertices = vert;
            this->numVerts = numVerts;
        }
        Polygon() {
            vertices = 0;
            numVerts = 0;
        }
        ~Polygon() {

        }
        ReleasePolygon()
        {
            if (RefCount == 0)
                delete this; // <-------- is this line ok?
            else
                RefCount--;
        }
}

Is this a proper way of calling the destructor at this point?

edited Jun 03 '13 at 07:14

Bernhard Barker

54,589
14
104
138

asked Jun 03 '13 at 07:08

Chanakya.sun

Let the destructor do the deleting and don't call it explicitly. A release method should only decrease the reference count. – juanchopanza Jun 03 '13 at 07:09
2

I don't think there is necessarily anything wrong about calling `delete` from within a release-method, but what confuses me is that your reference count is `static`. Why is that? – jogojapan Jun 03 '13 at 07:14
This seems to be written in a C++ derivative. – Zacrath Jun 03 '13 at 07:16
1

@Zacrath Why do you say that? – Bernhard Barker Jun 03 '13 at 07:17
How do you know it was created dynamically? What if it's on the stack? – Peter Wood Jun 03 '13 at 07:18
1

@Dukeling Because functions need to have a return type and static members need to be referenced with the scope operator (`::`) – Zacrath Jun 03 '13 at 07:22
@Zacrath Using `::` for static members [does not appear to be required](https://ideone.com/Oq9juA). And I wouldn't be too surprised if some compilers allow no return type, even if it's not proper C++ / consistent with the spec (?). – Bernhard Barker Jun 03 '13 at 07:30
this is a duplicate of C++: Delete this? only thq for u r comments :) – Chanakya.sun Jun 03 '13 at 10:57

Calling the destructor from a different method of the same class

0 Answers0