4

I even refered : Sonar Violation: Security - Array is stored directly

My code is as --->

    public final void setSelectedObjectsList(final ScheduleDTO[] selectedObjectsList) 
               //      Security - Array is stored directly    
               //The user-supplied array 'selectedObjectsList' is stored directly.      
{
            if (selectedObjectsList != null) {
                this.selectedObjectsList = selectedObjectsList.clone();
            } else {
                this.selectedObjectsList = null;
            }
        }

This is already taking care of defensive copy wonder why sonar is yelling at me right at function parameter.

This not not duplicate as Sonar Violation: Security - Array is stored directly

Again, Thank-you for your hyelp and time.

Community
  • 1
  • 1
Maulzey
  • 4,100
  • 5
  • 22
  • 30

1 Answers1

6

Not sure what Sonar is thinking but defensive shallow copying with clone() should work fine for arrays, as would Arrays.copyOf and System.arrayCopy().

On the other hand, since you are already calling the array a list: selectedObjectsList, you could also make it an actual list and refactor a bit:

public final void setSelectedSchedules(List<ScheduleDTO> selectedSchedules) {
    this.selectedSchedules = selectedSchedules != null ? new ArrayList<ScheduleDTO>(selectedSchedules) : null;
}
Jukka
  • 4,583
  • 18
  • 14
  • 6
    +1. And while you're at it, using null arrays or lists is a bad practices. These should never be null. Empty, yes. Null, no. – JB Nizet Jun 03 '13 at 19:37