Java Dice game won't work. need some advice

Question

I have a problem with my code, it's a simple dice game:

import java.util.Random;
class Zaruri {
    public static void main(String args[]) {
        Random roll = new Random();
        int[] zar = new int[2];

            for (int i = 0; i < 1; i++)  {
                for(int k = 0; k < 2; k++){
                zar[i] = (int) (roll* 6) + 1;
            }
            if (zar[0] == zar[1]) {
                System.out.println("Your numbers are : " + zar[0] + " and " + zar[1]  + "\nYou won! \nYEEEY!!");

            } else {
                System.out.println("Your numbers are : " + zar[0] + " and " + zar[1]  + "\nYou lost, better luck next time!");
            }
            }
    }
}

I don't know how to make it work,first it won't let print out the second dice(it comes allways 0) and if i put more then 1 roll and (roll.nextDouble * 6) + 1; it will work,but i don't want more then 1 roll. CAn you help me ? What am i doing wrong??

score 5 · Accepted Answer · answered Jun 18 '13 at 10:08

You don't need 2 for loops. Just 1 loop will do. Remove the outer i loop and let k loop do your random int generation.

for (int k = 0; k < 2; k++) {
    zar[k] = roll.nextInt(6) + 1; // k loop populates your array.
}
if (zar[0] == zar[1]) {
    System.out.println("Your numbers are : " + zar[0] + " and "
            + zar[1] + "\nYou won! \nYEEEY!!");

} else {
    System.out.println("Your numbers are : " + zar[0] + " and "
            + zar[1] + "\nYou lost, better luck next time!");
}

Tank you dude!:) it worked and i understand it now. Thanks again @R.J — Victor, Jun 18 '13 at 10:13

Richard Tingle · Answer 2 · 2013-06-18T10:26:00.040

There are a number of issues, i'll go through them 1 by 1

    for (int i = 0; i < 1; i++)  {
        for(int k = 0; k < 2; k++){
            zar[i] = (int) (roll* 6) + 1;
        }
        <snip rest of loop>

The loop with k in does nothing but repeat the line zar[i] = (int) (roll* 6) + 1; several times, it does nothing, this loop should be removed

        for (int i = 0; i < 1; i++)  {
            for(int k = 0; k < 2; k++){
                zar[i] = (int) (roll* 6) + 1;
            }
            if (zar[0] == zar[1]) {
                System.out.println("Your numbers are : " + zar[0] + " and " + zar[1]  + "\nYou won! \nYEEEY!!");

            } else {
                System.out.println("Your numbers are : " + zar[0] + " and " + zar[1]  + "\nYou lost, better luck next time!");
            }
        }

The print statements are within the for loop, so it prints out every time through the loop, the first time through the loop only the first die will be set, the second time only the first two, etc etc.

zar[i] = (int) (roll* 6) + 1;

roll is of class random, it is not a number but generates random numbers, this should be

zar[i] = (int) (roll.nextDouble()* 6) + 1;

or more sensibly (as you want an int in the end anyway

zar[i] = roll.nextInt()+ 1;

for (int i = 0; i < 1; i++)

Numbers from i=0 to i<1 is just one number, 0, dice 1 is never set because its only goes through the loop once

score 0 · Answer 3 · answered Jun 18 '13 at 10:07

0

Try to use Math.random() instead of Random()

answered Jun 18 '13 at 10:07

Gilles V.

1,412
13
20

score 0 · Answer 4 · answered Jun 18 '13 at 10:07

0

I don't see why you have two loops, and especially the one with k as an index. You are not using that k anywhere. Try this:

 for (int i = 0; i < 2; i++)  {
     zar[i] = roll.nextInt(6) + 1;
 }

answered Jun 18 '13 at 10:07

darijan

9,725
25
38

score 0 · Answer 5 · edited May 23 '17 at 11:58

0

try this instead :

int Low = 10;
int High = 100;
int R = r.nextInt(High-Low) + Low;

SOURCE : How can I generate random number in specific range in Android?

or Java Generate Random Number Between Two Given Values

edited May 23 '17 at 11:58

Community

1
1

answered Jun 18 '13 at 10:08

wazaminator

245
3
15

score 0 · Answer 6 · answered Jun 18 '13 at 10:13

Delete the first loop with the i and let only the k loop. Then it won't logically work and always print 0 because you don't generate a random number. You must do zar[i]=roll.nextInt(6)+1; because the range is from 0 (included) and 6 (excluded). Logically you must add 1 whatever will be the result to obtain a 1-6 range.

Java Dice game won't work. need some advice

6 Answers6