Issue with switch case in android

Question

In order increase the levels after 10 ProjectilesDestroyed, i have set switch case, where for the 1st level after 10 projectiles Destroyed 2nd level is displayed but from 2nd level its increased for every 2 projectilesDestroyed and also the levels are increases beyond 10, how should i make it a difference of 10 to increases the levels. this is how i implemented

if (++_projectilesDestroyed > 5)
            {
                _projectilesDestroyed = 0;

            //  for(level=1; level<12; level++)
                switch(level)
                   {
                   case 1:
                       _projectilesDestroyed = 10;
                   System.out.println("case 1");
                                      break;
                   case 2:
                       _projectilesDestroyed = 20; 
                       System.out.println("case 2");
                       break;
                   case 3:
                       _projectilesDestroyed = 30;
                       System.out.println("case 3");
                       break;
                   case 4:
                       _projectilesDestroyed = 40;
                       System.out.println("case 4");
                       break;
                   case 5:
                       _projectilesDestroyed = 50;
                                         break;
                   case 6:
                       _projectilesDestroyed = 60;
                                    break;
                   case 7:
                       _projectilesDestroyed = 70;
                                   break;
                   case 8:
                       _projectilesDestroyed = 80;
                                      break;
                   case 9:
                       _projectilesDestroyed = 90;
                                    break;
                   case 10:
                       _projectilesDestroyed = 100;
                       System.out.println("case 10");
                       break;
                   default: break;
                   }
                 addLevel();

addLevel() method.

public void addLevel() {
    level = level + 1;
                showLevel(level);
          }

Even though if i add break; on all the cases from level 2, its getting updated for every 2 projectilesDestroyed but i want when it reached 10.

In this case, if you are only assigning values based on your current level, you could use `_projectilesDestroyed = level * 10` or fill an array beforehand like this `int[] projectilesDestroyed = {10, 20, ... 100}` — Michael Lang, Jul 06 '13 at 10:24
If I get you correctly, you are saying that your `level` is increased for every 2 projectiles destroyed. I think the problem now is not with your code posted but with the code which calls the `addLevel()` method. — Michael Lang, Jul 06 '13 at 10:36
have you done with the code or still waiting for the answer ? — Akarsh M, Jul 09 '13 at 05:07
Possible duplicate of [Why do we need break after case statements?](http://stackoverflow.com/questions/2710300/why-do-we-need-break-after-case-statements) — Raedwald, Jan 24 '16 at 16:57

score 0 · Answer 1 · answered Jul 06 '13 at 10:16

YOu are missing break satements after case blocks.

      case 1:
                   _projectilesDestroyed = 10;
                   System.out.println("case 1");
                   //  missing break here and in the following case staments

If you don't put break statement after the case, then the next case statement will be executed sequentially and so on.

score 0 · Answer 2 · edited Jun 20 '20 at 09:12

You have forgotten to add the break statements for each case. It will be a fall-through.

case 1:
   _projectilesDestroyed = 10; 
    System.out.println("case 1");
    break; // to prevent falling through

Look at JLS 14.11

If code is not to fall through case to case in this manner, then break statements should be used.

If one of the case constants is equal to the value of the expression, then we say that the case matches, and all statements after the matching case label in the switch block, if any, are executed in sequence.

Raghunandan · Answer 3 · 2013-07-06T10:26:15.477

0

   case 1:
           _projectilesDestroyed = 10;
            System.out.println("case 1");
   break; // missing

You are missing break statement for every case.

Each break statement terminates the enclosing switch statement. Control flow continues with the first statement following the switch block. The break statements are necessary because without them, statements in switch blocks fall through:

Check the docs for more info

http://docs.oracle.com/javase/tutorial/java/nutsandbolts/switch.html

edited Jul 06 '13 at 10:26

answered Jul 06 '13 at 10:16

Raghunandan

132,755
26
225
256

@jack your update does not reflect adding break statement. check the docs and the example `SwitchDemoFallThrough`. Make sure you have break for all case. – Raghunandan Jul 06 '13 at 10:29
@jack you are calling `addLevel` outside switch. – Raghunandan Jul 06 '13 at 10:38
if i call it inside the switch, level is not getting updated @Raghunandan – samm Jul 06 '13 at 10:48

score 0 · Answer 4 · answered Jul 06 '13 at 10:19

fall through........

As per switch docs:

Each break statement terminates the enclosing switch statement. Control flow continues with the first statement following the switch block.

The break statements are necessary because without them, statements in switch blocks fall through:

You have to add the break after the each case

 switch(level)
                   {
                   case 1:
                       _projectilesDestroyed = 10;
                   System.out.println("case 1");
                   break;

this works only for the first cases, from second levels are updated for every 2 ProjectilesDestroyed. @Baadshah — samm, Jul 06 '13 at 10:28

score 0 · Answer 5 · answered Jul 06 '13 at 10:53

I guess your problem is with the first if statement:

if (++_projectilesDestroyed > 5)

Once you have destroyed more than 5 projectiles, you will always enter the block and increase your level. You will probably need some different variables here, like this

if(++_projectilesDestroyed > _projectilesRequired)

and set your _projectilesRequired according to your switch-case statement above or using _projectilesRequired = level * 10

Issue with switch case in android

5 Answers5

fall through........