mysqli connection not working inside function?

Question

I'm having some problems performing a mysql query inside a php function. The error I am getting is

Notice: Undefined variable: link in C:\path\api\inc\restFunctions.php on line 16

There are several files calling each other so I will attempt to outline the necessary information.

URL Accessed:

localhost/serverList/api/rest.php?action=allServers

serverList/api/rest.php

<?php
include 'inc/restFunctions.php';

$possibleCalls = array('allServers','allEnvs','allTypes','false');
if(isset($_GET['action'])){
    $action = $_GET['action'];
}
else{
    $action = 'false';
}


if(in_array($action,$possibleCalls)){
    switch ($action){
        case 'allServers':
            $return = allServers();
        break;
        case 'allEnvs':
            $return = allEnvs();
        break;
        case 'allTypes':
            $return = allTypes();
        break;
        case 'false':
            $return = falseReturn();
        break;
    }
}

serverList/api/inc/restFunctions.php

<?php
include ('inc/config.php');

function allServers(){
    $serverInfoQuery = "SELECT * FROM servers"
    $allServerResults = $link->query($serverInfoQuery);
    $json = array();
    while($row = $allServerResults->fetch_assoc()){
        $json[]['serverID'] = $row['serverID'];
        $json[]['environment'] = $row['environment'];
        $json[]['type'] = $row['type'];
        $json[]['serverIP'] = $row['serverIP'];
        $json[]['serverDescription'] = $row['serverDescription'];
        $json[]['serverCreatedBy'] = $row['serverCreatedBy'];
        $json[]['serverCreatedDtTm'] = $row['serverCreatedDtTm'];
        $json[]['serverUpdatedBy'] = $row['serverUpdatedBy'];
        $json[]['serverUpdatedDtTm'] = $row['serverUpdatedDtTm'];
    }
    $jsonResults = json_encode($json);
    return $jsonResults;
}
?>

serverList/api/inc/config.php

<?php
$host = 'localhost';
$user = 'userName';
$password = 'password';
$database = 'database';
$link = new mysqli($host, $user, $password, $database);
if (mysqli_connect_errno()) {
    exit('Connect failed: '. mysqli_connect_error());
}
?>

I have verified that the query being called works. I also verified that the connection info (masked above) works by using a different page of this software that queries the db.

I'm assuming I must have missed a quote or paren somewhere, but I'm baffled as to where it might be.

[Reference: What is variable scope, which variables are accessible from where](http://stackoverflow.com/q/16959576/285587) — Your Common Sense, Jul 09 '13 at 17:46
Variable scope would certainly make sense. I'm not sure I'm attempting to call a local variable from a non local place? I believe I'm only calling global variables? Unless there is something that I'm missing — mhopkins321, Jul 09 '13 at 17:49
look at the second box at http://php.net/manual/en/language.variables.scope.php Your `$link` in `config.php` is global scope, but you are accessing a local scope `$link` in your function. Either need to add it as a function parameter `allServers($link)`, or declare `global $link` in your function. the link from @YourCommonSense clearly describes this. — Sean, Jul 09 '13 at 17:50
Please pass your link to the function. Using global is very bad practice! — Dave Chen, Jul 09 '13 at 18:01

score 11 · Accepted Answer · answered Jul 09 '13 at 17:51

11

The problem is with PHP variable scoping. Add this line inside of allServers() function before you refer to the $link variable for the first time:

global $link;

See more here: http://php.net/manual/en/language.variables.scope.php

answered Jul 09 '13 at 17:51

romka

94
5

Mikk · Answer 2 · 2013-11-12T02:27:31.090

In my opinion using global variables is not a good solution. You might override $link ($link is rather usual name for a variable you may be using for another purposes) variable in some scope by accident, resulting in lot's of confusion and difficult debugging. Just pass it as a function parameter - much cleaner and easier to read:

function AllServers($link) {
    $serverInfoQuery = "SELECT * FROM servers";
    $allServerResults = $link->query($serverInfoQuery);
    //More PHP code
}    

if(in_array($action,$possibleCalls)){
    switch ($action){
        case 'allServers':
            $return = allServers($link);
        break;
    }
}

To be honest, even better solution would be using some generic classes/functions to establish your mysql connection like so:

class DB {

    private static $link = null;

    public static function getConnectionResource() {
        //In that way we "cache" our $link variable so that creating new connection 
        //for each function call won't be necessary
        if (self::$link === null) {
            //Define your connection parameter here
            self::$link = new mysqli($host, $user, $password, $database);
        }
        return self::$link;
    }
}

function getAllServers() {
    $link = DB::getConnectionResource();
    //Preform your query and return results
}

score -1 · Answer 3 · answered Jul 09 '13 at 17:51

-1

Use global variable

function allServers(){

global $link

...
...
...
... your code follows

answered Jul 09 '13 at 17:51

Afsar

3,104
2
25
35

mysqli connection not working inside function?

3 Answers3

Linked

Related