Bad parameter when using save() on Image

Question

I am having a bit of trouble with saving an Image, it says "Bad paremeter" on the line where I try and save the image.

I'm not sure if it's how I am creating the image or if it's just saving that's the problem.

public static void Fullscreen()
{
    string fileName = Helper.RandomStr(10) + ".png";

    try
    {
        var image = ScreenCapture.CaptureFullscreen();
        image.Save(fileName, ImageFormat.Png);

        System.Diagnostics.Process.Start(fileName);
    }
    catch (Exception ex)
    {
        MessageBox.Show("Unable to capture fullscreen because: " + ex.ToString() + "\r\n\r\nFile: " + fileName);
    }
}

Edit:

Here is the method that gets the Bitmap

    public static Bitmap CaptureFullscreen()
    {
        using (Bitmap bmp = new Bitmap(ScreenDimensions.Width, ScreenDimensions.Height))
        {
            using (Graphics g = Graphics.FromImage(bmp))
            {
                g.CopyFromScreen(Point.Empty, Point.Empty, bmp.Size);
            }

            return bmp;
        }
    }

What does Helper.RandomStr(10) do? Is a valid path in `filename`? — Andy, Jul 12 '13 at 13:11
take a look here http://stackoverflow.com/questions/5049122/how-to-capture-the-screen-shot-using-net — Christian Phillips, Jul 12 '13 at 13:12
You have to document what `ScreenCapture.CaptureFullscreen` is. — LarsTech, Jul 12 '13 at 13:27
Have you tried to give an defined Point variable to "CopyFromScreen" method. E.g. CopyFromScreen(new Point(0,0),new Point(800,600),bmp.Size) ? — mstrewe, Jul 12 '13 at 14:23
Don't dispose the bitmap before returning it from your method. That is supposed to go bang! — Hans Passant, Jul 14 '13 at 19:36
Hans, that was the reason why it wasn't working. I figured it out before I saw this but thanks! — Ben, Jul 15 '13 at 10:41

stepandohnal · Answer 1 · 2013-07-13T20:20:39.660

1

Bad parameter is the way GDI+ tells that there was some problem. Its a shame that the errors are not very much descriptive.

First try to wrap image parameter to Bitmap constructor like:

image = new Bitmap(image);

This forces to process the bitmap immediately.

It was even simpler, remove using on the bitmap.

edited Jul 13 '13 at 20:20

answered Jul 12 '13 at 13:20

stepandohnal

457
4
13

score 0 · Answer 2 · answered Jul 12 '13 at 13:27

0

Try using a known path and see if starts working. If so then you might want a new random string generator that makes valid paths or a different way of naming the file.

answered Jul 12 '13 at 13:27

noelicus

14,468
3
92
111

Bad parameter when using save() on Image

2 Answers2