OnMenuItemSelected isn't called when layout is set for menu item

Question

I have a menu which is inflated from main_menu.xml:

<menu xmlns:android="http://schemas.android.com/apk/res/android">
    <item 
        android:id="@+id/act_sync" 
        android:showAsAction="always"
        android:actionLayout="@layout/sync_action"
        android:icon="@android:drawable/ic_popup_sync" />
</menu>

and here is the code in the activity:

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.main_menu, menu);
    return true;
}
@Override
public boolean onOptionsItemSelected(MenuItem item) {
    MyMessageHandler.debug("menu item selected");
    switch(item.getItemId()){
    case R.id.act_sync:
        sync();
        return true;
    }
    return super.onOptionsItemSelected(item);
}

But onOptionsItemSelected is not called when I touch the menu item. When I remove the actionLayout attribute of the menu item, it works fine. How can I fix this?
Thanks.

score 32 · Accepted Answer · answered Jul 20 '13 at 17:39

32

you should use below snippet ( Just for reference )

@Override
    public boolean onCreateOptionsMenu(Menu menu) {
        MenuInflater inflater = getMenuInflater();
        inflater.inflate(R.menu.main_menu, menu);
        final Menu m = menu;
        final MenuItem item = menu.findItem(R.id.ActionConnection);
        item.getActionView().setOnClickListener(new OnClickListener() {

            @Override
            public void onClick(View v) {   
                sync();
            }
        });
        return true;
    }

answered Jul 20 '13 at 17:39

Vipul

27,808
7
60
75

3

Thanks. I had already tested the `item.setOnMenuItemClickListener` but it didn't work. The point was to get my custom view and set clickListener on it. Thanks for your help :) even though, the onClick() should not be annotated by @Override. I edit your response to the version that works, and also is a bit more digest ;) – Alireza Mirian Jul 20 '13 at 18:05
This is the only solution that worked for me. I tried setOnMenuItemClickListener, onMenuItemSelected, etc. – crubio Sep 09 '14 at 15:06
click listener should be on layout i think – Jemshit Feb 15 '16 at 13:14

score 26 · Answer 2 · edited Sep 14 '15 at 06:49

26

In addition to the answer provided by Vipul Shah.

Make sure you disable the clickable option of all items in your action layout:

android:clickable="false"

Otherwise, it may steal the click so that you still cant receive onClick call back.

edited Sep 14 '15 at 06:49

Shubham Chaudhary

47,722
9
78
80

answered May 29 '14 at 14:44

Alvin

515
6
11

1

Hours searching. Thanks! – Juan Aguilar Guisado Oct 19 '14 at 11:07
Saved my life...! Without this the answer wouldn't work... Thanks! – Saravanabalagi Ramachandran Oct 17 '15 at 18:44
Thanks a lot. Saved me from killing back pain :) – Kamalakannan J Jan 23 '16 at 19:32
Very important. Thank you for this answer. This one + the one from Vipul Shah did it for me... – fraxool May 05 '16 at 14:47
Many Thanxxxx, you save my time – Osama Ibrahim Jan 13 '20 at 08:17

OnMenuItemSelected isn't called when layout is set for menu item

2 Answers2

Linked