Strange implementation of Guava LongMath.checkedAdd

Question

public static long checkedAdd(long a, long b) {
    long result = a + b;
    checkNoOverflow((a ^ b) < 0 | (a ^ result) >= 0);
    return result;
}

I am interested why boolean logical | is used here. Why not to use conditional short circuited ||?

Not that uncommon in code that wants to avoid branching for performance reasons. — molbdnilo, Aug 16 '13 at 13:37

score 1 · Accepted Answer · edited May 23 '17 at 11:49

1

The first comment in that class:

// NOTE: Whenever both tests are cheap and functional, it's faster to use 
// &, | instead of &&, ||

edited May 23 '17 at 11:49

Community

answered Aug 16 '13 at 15:09

Louis Wasserman

1 Answers1