Why can't I set "this" to a value in C#?

Question

I am using Dapper.net Extensions and I would like to be able to retrieve a Photo object and set 'this' to it without having to set each property individually. What would be the best way to accomplish this? In the code below it says I cannot assign to 'this' because it is readonly.

public class Photo
{
    public Int32 PhotoId { get; set; }
    public Guid ObjectKey { get; set; }
    public Int16 Width { get; set; }
    public Int16 Height { get; set; }
    public EntityObjectStatus ObjectStatus { get; set; }
    public PhotoObjectType PhotoType { get; set; }
    public PhotoFormat2 ImageFormat { get; set; }
    public Int32 CategoryId { get; set; }

    public Photo(int pPhotoId)
    {
        Load(pPhotoId);
    }

    public void Load(int pPhotoId)
    {
        using (SqlConnection conn = new SqlConnection(Settings.Conn))
        {
            conn.Open();
            this = conn.Get<Photo>(pPhotoId);
        }
    }
}

score 5 · Accepted Answer · answered Aug 17 '13 at 04:41

Unfortunately, there is no way to do this without setting the properties. An elegant way to do this would be to use a static method to load the Photo. I don't have the extension you are using, so the following code example is a bit different, but it should work as an example.

using System;
using System.Collections.Generic;
using System.Data.SqlClient;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace ConsoleApplication1
{
    public class Photo
    {
        public Int32 PhotoId { get; set; }
        public Guid ObjectKey { get; set; }
        public Int16 Width { get; set; }
        public Int16 Height { get; set; }
        public Int32 CategoryId { get; set; }

        public static Photo Load(int id)
        {
            using (SqlConnection conn = new SqlConnection("ABC"))
            {
                return conn.Get<Photo>(id);
            }
        }
    }
    class Program
    {
        static void Main(string[] args)
        {
            Photo photo = Photo.Load(1);
        }
    }
}

Some more discussion here from Jon Skeet about the topic: http://bytes.com/topic/c-sharp/answers/513887-cannot-assign-because-read-only

Simon Whitehead · Answer 2 · 2013-08-17T04:45:11.990

2

this is read-only ... so no, you can't do that.

There are frameworks like AutoMapper for mapping between objects. Perhaps you should look into that.

That being said.. I think your design could use a re-think. You've reached the point where your domain objects are loading data themselves and you've realised you'll be writing repetitive mapping code. I think it's time to extract this into a "Service" class and remove the logic from your domain objects altogether (thereby, making your question void, since you wouldn't encounter that situation anyway).

edited Aug 17 '13 at 04:45

answered Aug 17 '13 at 04:37

Simon Whitehead

63,300
9
114
138

A service class to handle CRUD operations was an excellent suggestion and one I have implemented. I went exploring for an efficient way to remove redundant code and your suggestion helped! – Greg Rogoszewski Aug 17 '13 at 16:13

score 2 · Answer 3 · answered Aug 17 '13 at 04:37

You can't, you must copy the methods individually, however you can use methods like reflection or a library like AutoMapper to make it easier to do.

That being said, I think a better plan is make Load static and have it return a new Photo instance, this is the pattern you see most often in the .NET framework itself.

public static Photo Load(int pPhotoId)
{
    using (SqlConnection conn = new SqlConnection(Settings.Conn))
    {
        conn.Open();
        return conn.Get<Photo>(pPhotoId);
    }
}

Why can't I set "this" to a value in C#?

3 Answers3

Linked