Why isn't this onclick JavaScript call working?

Question

HTML

<div id="test"></div>
<input type="button" value="Go" onclick="test()" />

JavaScript

function test() {
    alert("Test!");
}

Fiddle

http://jsfiddle.net/MVBrS/11/

The other options wrap the code in a closure so your functions won't be available in the global scope. The best way is to attach your events _in JavaScript_, not in the markup. Look for `addEventListener`. — elclanrs, Aug 20 '13 at 00:06

score 0 · Answer 1 · edited May 23 '17 at 11:56

Please look at this one, it is about jsfiddle code frames separation:

Inline event handler not working in JSFiddle

Of course, if you were running the same code embedded on plain HTML it works normally, having the alerted popup appearing.

<!DOCTYPE html>
  <html>
    <head>
      <script>
        function test() {
          alert("Test!");
        }
      </script>
     </head>
     <body>
       <div id="test"></div>
       <input type="button" value="Go" onclick="test()" />
     </body>
  </html>

score -2 · Answer 2 · edited May 23 '17 at 12:20

when you do

onclick="test()"

as an attribute of the input element, you are setting the result of the call test() (in your case 'null') as the click event handler

you probably want to do this

onclick="test"

instead, which will set the actual 'test' function as the handler,

or even better, follow the following guidelines: unbtrusive javascript or unobtrusive JS (2),.. you get the point ;)

Why isn't this onclick JavaScript call working?

2 Answers2