How can i call a function that is in another controler (Angular js)

Question

in ControllerOne

$scope.displayReport = function( status ){

   statusCkeck( status ) ;
}

statusCkeck() ; is in another controller -controllerTwo

How can i call this function from one controller to another

i tried angular.element(document.getElementById('controllerTwo')).scope().statusCheck();

But it throwing error.

Please suggest

But my case is different ,i just want to call another function ,no service calls — Prashobh, Sep 28 '13 at 11:58
That is not angular way. Use a service if you want to share things between controllers. — Jesus Rodriguez, Sep 28 '13 at 12:06

score 7 · Accepted Answer · answered Sep 28 '13 at 12:08

You should use a service instead to avoid muddying up the controllers with code that calls functions in other controllers. If you're sharing functions, just define them in a service and inject that service where needed.

angular.module('myApp', [])
  .factory('myService', function() {
    return {
      sharedFunction: function (foo, bar) {
        return foo + bar;
      }
    }
};

Norbert Pisz · Answer 2 · 2013-09-28T11:57:47.410

1

You can get scope:

angular.element(document.getElementById('yourControllerElementID')).scope().get()

But yourControllerElementID should be ElementID not ControlerName!

For example:

<div id="elemID" ng-controller="YourController"></div>

So elemId is id of element with YourController.

edited Sep 28 '13 at 11:57

answered Sep 28 '13 at 11:51

Norbert Pisz

3,392
3
27
42

Here i confused ,what is Element ID in the controller – Prashobh Sep 28 '13 at 11:54
See edit. Just take Id of element where you using your controller. – Norbert Pisz Sep 28 '13 at 11:58
This should work but it's a terrible idea. Tightly coupling your controllers like that leads to spaghetti code. – Jason Sep 28 '13 at 12:18
Yes this is not good solution. Maybe he can move method to service and use it globally :) – Norbert Pisz Sep 28 '13 at 12:21

How can i call a function that is in another controler (Angular js)

2 Answers2

Linked