C++ Split Wide Char String

Question

I'm trying to split a WideChar String in to an array, Here is the way I'm doing this :<>

WCHAR* Message = _T("This is a sample text"):
wchar_t *pwc;
CStringArray Command;
pwc = wcstok(Message, L" ");
int Count = 0;
while (pwc != NULL) {
    pwc = wcstok(NULL, L" ");
    Command.Add(pwc);
    Count++;
}

for (int i = 0 ; i <= Count ; i++)
{
    AfxMessageBox(Command[i]);
}

The problem is I do not have "This" in my final result array
Whats wrong ?

Works for me (once I've fixed up the code to compile in a Linux environment, but that's wcstok() taking a third parameter to allow reentrancy, shouldn't change the behaviour. You are talking of an "array", which makes me think you are perhaps doing something wrong in your copying of the elements out of the string? — Mats Petersson, Sep 29 '13 at 13:40
I have edited the question and changed the code to what Im currently using — Shahriyar, Sep 29 '13 at 13:47
If you'd run the code you originally showed us you'd have seen it working - which might have helped you work out why this version doesn't. — Alan Stokes, Sep 29 '13 at 13:57

score 2 · Accepted Answer · answered Sep 29 '13 at 13:55

2

You need to move the call to Command.Add before the assignment to pwc in the loop - as it stands you're moving on to the second token before doing your first Add.

answered Sep 29 '13 at 13:55

Alan Stokes

18,815
3
45
64

Thanks for answer, Do I need to `delete pwc;` when I finished my work ? – Shahriyar Sep 29 '13 at 14:00
1

No. (It'll be null by then anyway.) You don't `new` anything, so there's nothing to `delete`. – Alan Stokes Sep 29 '13 at 14:02

score 1 · Answer 2 · answered Sep 29 '13 at 13:38

1

I am having no issues with your source. All string components are printing perfectly.

Here's my full working code:

#include "stdafx.h"
#include <wchar.h>

int main(int argc, char *argv[])
{
    wchar_t wcs[] = L"This is a sample string";
    wchar_t *pwc;
    pwc = wcstok(wcs, L" ");
    while (pwc != NULL) {
        wprintf(L"%ls\n", pwc);
        pwc = wcstok(NULL, L" ");
    }
}

answered Sep 29 '13 at 13:38

Steve

486
2
8
19

That would be better as a comment - it doesn't really answer the question. (Thanks for not using `_T` though!) – Alan Stokes Sep 29 '13 at 13:44
1

I agree, but I have little reputation here ;) – Steve Sep 29 '13 at 13:59
Here, free reputation. – Mouradif Aug 03 '16 at 16:03

C++ Split Wide Char String

2 Answers2

Linked