function should return array but returns NULL instead

Question

I have this function that should return an array, but it returns NULL instead. I think it might have to do with the size of the array it generates, because sometimes it does work properly. I have tried to do a var_dump before the return, which always showed the array I needed, however a var_dump of the output of the function just shows NULL.

function getAllUploads($videoFeed, $videos = array(), $counter = 1){
    foreach($videoFeed as $videoEntry){
        if($videoEntry->extensionElements[6]->extensionAttributes['permission']['value'] == "allowed"){
            $videos[] = array("videoID" => $videoEntry->getVideoId(), "uploaded" => ytToMySQLDateTime($videoEntry->getPublished()->getText())); //date('Y-m-d H:i:s', $videoEntry->getPublished()->getText())
        }
        $counter++;
    }

    try{
        $videoFeed = $videoFeed->getNextFeed();
    }catch(Zend_Gdata_App_Exception $e){
        return $videos;
    }

    if($videoFeed){
        getAllUploads($videoFeed, $videos, $counter);
    }
}

This function does not return anything unless a `Zend_Gdata_App_Exception` is thrown. — TheWolf, Sep 29 '13 at 21:28
Yea, I know. But the exception should always be thrown eventually. Still I'll try returning some where else as well.. — CupOfTea696, Sep 29 '13 at 21:31
If the exception is supposed to be thrown some time during the recursion, the answer below is correct as you need to `return` the value the recursion gives you. — TheWolf, Sep 29 '13 at 21:32

score 2 · Accepted Answer · answered Sep 29 '13 at 21:29

You should return the function inside the last if() statement

function getAllUploads($videoFeed, $videos = array(), $counter = 1){
    foreach($videoFeed as $videoEntry){
        if($videoEntry->extensionElements[6]->extensionAttributes['permission']['value'] == "allowed"){
            $videos[] = array("videoID" => $videoEntry->getVideoId(), "uploaded" => ytToMySQLDateTime($videoEntry->getPublished()->getText())); //date('Y-m-d H:i:s', $videoEntry->getPublished()->getText())
        }
        $counter++;
    }

    try{
        $videoFeed = $videoFeed->getNextFeed();
    }catch(Zend_Gdata_App_Exception $e){
        return $videos;
    }

    if($videoFeed){
        return getAllUploads($videoFeed, $videos, $counter);
    }
}

Can't you even loose the last 'if'? Otherwise you need another return. — FloydThreepwood, Sep 29 '13 at 21:30
Well the `catch` does the other return, if it doesn't catch the `if($videoFeed)` will return — doitlikejustin, Sep 29 '13 at 21:31

function should return array but returns NULL instead

1 Answers1