IF/ELSE statement validation issue

Question

I have the following code:

View.OnClickListener calcu = new View.OnClickListener() {
    public void onClick(View v) {
        double q;
        String d = "";
        double factor = cpi[to] / cpi [from];
        DecimalFormat decimalFormat = new DecimalFormat("0.##");
        if (eNum.getText().toString().length() <= 0 || bFrom.getText() == "- Select a Year -" || bTo.getText() == "- Select a Year -") {
            if (eNum.getText().toString().length() <= 0) {
                d += "Enter Dollar Amount";
                eNum.setTextColor(Color.RED);
            }
            if (bFrom.getText() == "- Select a Year -") {
                d += "Select a Year";
                bFrom.setTextColor(Color.RED);
            }
            if (bTo.getText() == "- Select a Year -") {
                d += "Select a Year";
                bTo.setTextColor(Color.RED);
            }
        }
        else {
            dollarAmount = factor * Double.parseDouble(eNum.getText().toString());
            String value = Double.toString(dollarAmount);
            if (value.charAt(value.length() - 2) == '.') {
                value += "0";
            }
            displayToast("Dollar: " + value);

            if (cpi[to] != cpi[from]) {
                double f, y;
                if (cpi[to] > cpi[from]) {
                    f = cpi[to] / cpi [from];
                    y = to - from;
                }
                else {
                    f = cpi[from] / cpi[to];
                    y = from - to;
                }
                q = Math.pow(f, 1/y);
                q = (q-1)*100.0;
                q = Math.round(q*100.0)/100.0;
                displayToast("Inflation: " + String.valueOf(decimalFormat.format(q)));
            }
        }
    }
};

displayToast() is a function which displays the Toast message to the user.

eNum is an EditText

bFrom and bTo are Buttons

What I want to happen when the onClick method is activated:

If the eNum is empty, I want to make the text color RED.
If the bFrom and bTo buttons text is - Select a Year -, I want to make the text color RED.
If #1 and #2 is not true than display the Toasts.

Right now when I click, nothing is happening. How do I fix the above code to work correctly?

@ChristopherFrancisco Yes I did. Sorry forgot to post that part :) — Si8, Oct 11 '13 at 14:10
Seriously, how many times has Java string comparison been asked on SO? Or in life? — Dave Newton, Oct 11 '13 at 14:20

score 2 · Accepted Answer · answered Oct 11 '13 at 14:07

2

Change this:

bFrom.getText() == "- Select a Year -"

To this:

bFrom.getText().equals("- Select a Year -")

And the same would go for your bTo.getText() == "- Select a Year -") line.

Use .equals() to compare objects (e.g. Strings) and == for primitives

answered Oct 11 '13 at 14:07

Razgriz

7,179
17
78
150

score 1 · Answer 2 · answered Oct 11 '13 at 15:17

1

If you are comparing string then you need to use .equals.

answered Oct 11 '13 at 15:17

Sachin M

151
1
1
12

Yeah, but someone else already said the same thing an hour ago. – Dave Newton Oct 11 '13 at 15:23
Correct. Just highlighted the problem he is facing. – Sachin M Oct 11 '13 at 15:26
@SachinM Thank you for the response and I appreciate it. Do not pay any mind to Dave Newton! – Si8 Oct 11 '13 at 18:42

IF/ELSE statement validation issue

2 Answers2