jQuery regular expression does not validate

Question

I have a Regular Expression for matching URLs. It should not match the following.

www.yammercom
http://www.yammer
www.yammer..com

Regular Expression

/^((((ht|f)tps?:\/\/)*(www\.)?|((ht|f)tps?:\/\/)(www\.)?)*)[a-z0-9-\.]+\.[a-z]{2,4}\/?([^\s<>\#%"\,\{\}\\|\\\^\[\]`]+)?$/

what mistake I am making in my regular expression??

Try it

Rubular demo

Can you provide us the free spacing RE？Single line RE is really hard for us to read... — Herrington Darkholme, Oct 16 '13 at 07:27
What do you search for with this: `([^\s<>\#%"\,\{\}\\|\\\^\[\]`]+)` — Manolo, Oct 16 '13 at 08:06

TheOnly92 · Answer 1 · 2013-10-16T09:33:01.103

1

If you need a regex to match a url, you can take a look here:

http://mathiasbynens.be/demo/url-regex

Which you'll find insanely long regex that most will only pass half the test. This should tell you why it's not a good idea to try to validate it in 1 line of regex.

edited Oct 16 '13 at 09:33

answered Oct 16 '13 at 07:29

TheOnly92

1,723
2
17
25

I've stated the changes on the first line, here is the correct one: http://rubular.com/r/frCdtvj3Vp – TheOnly92 Oct 16 '13 at 08:12
I cant understand what you would like to say?? In the link u have provided http://rubular.com/r/frCdtvj3Vp accepts www.yammer. It is incorrect as per my requirement – Sam Oct 16 '13 at 08:54
^((((ht|f)tps?:\/\/)*(www\.)?|((ht|f)tps?:\/\/)(www\.)?)*)[a-z0-9\-\.]+\.[a-z]{2,4}\/??$. it seems to work. but 3rd conditon only not satisfied – Sam Oct 16 '13 at 09:06
Okay, I just looked at the title and found that the regex was incorrect, I've edited the answer for an expression that matches URL. – TheOnly92 Oct 16 '13 at 09:29

score 1 · Answer 2 · answered Oct 16 '13 at 07:57

After free spacing your RE, it turns out that there are some problems... enter image description here

You do not need match protocol using *, and the last [] does not make much sense to me...(maybe you can update your question.)

My tweak is here. See online demo. http://rubular.com/r/12J7ZRo4Qx

/^(
    (https?|ftp)
    :\/\/                      #protocol
  )?                           #is optional
  (www\.)?                     #optional www
  [-a-z0-9]+                   #place - first so it means literally
  \.
  [a-z]{2,4}                   #trailing hostname
  (                            #match pathname
    \/                         #a slash is required
    [-a-z0-9]+                 #same as hostname
  )*
/x

The x flag stands for free-spacing, as in perl.

Anyway, matching url is quite common. My version is not good nor bullet-proofing. It's just for demonstration. If you need more solid RE, check this http://net.tutsplus.com/tutorials/other/8-regular-expressions-you-should-know/.

The book Mastering Regular Expression is another definitive guide

This question shall also help. http://stackoverflow.com/questions/1141848/regex-to-match-url — Herrington Darkholme, Oct 16 '13 at 08:02
^((((ht|f)tps?:\/\/)*(www\.)?|((ht|f)tps?:\/\/)(www\.)?)*)[a-z0-9\-\.]+\.[a-z]{2‌,4}\/??$. it seems to work. but 3rd conditon id not only satisfied — Sam, Oct 16 '13 at 09:06

score 0 · Answer 3 · answered Oct 16 '13 at 07:51

0

I think this will work:

/^((((ht|f)tps?:\/\/)*(www\.)?|((ht|f)tps?:\/\/)(www\.)?)*)[a-z0-9\-\.]+\.[a-z]{2,4}\/?([^\s<>\#%"\,\{\}\\|\\\^\[\]`]+)?$/

You have to scape the -

answered Oct 16 '13 at 07:51

Manolo

24,020
20
85
130

jQuery regular expression does not validate

3 Answers3