Copy constructor error c2039

Question

hy guys! I have a code that gives me headaches. I would like some help please. This is my .h file.

#include <iostream>
#include <string>
using namespace std;

namespace UI{
class Comanda
{
private:
    const string _nume;
public:
    Comanda();
    Comanda(const string &nume);

    virtual ~Comanda();
    const string& Nume() const;
    virtual void AsteaptaEnter();
    virtual void Execute();
};
};

And the .cpp:

#include <iostream>
#include <string>
#include "Comanda.h"
#include "Exceptii.h"

using namespace std;
using namespace UI;

Comanda::Comanda()
{
    cout << "Comanda()" << endl;
}

Comanda::Comanda(const string &nume)
{
    _nume = nume._nume;
}

The compiler shows me this error:

error C2039: '_nume' : is not a member of 'std::basic_string<_Elem,_Traits,_Ax>'

What should i do? Thanks in advance!

Note that `using namespace std;` in a header is [considered evil](http://stackoverflow.com/questions/5849457/using-namespace-in-c-headers). — Cornstalks, Nov 26 '13 at 20:21
@jdc : tried that too...and then it shows me this: error C2678: binary '=' : no operator found which takes a left-hand operand of type 'const std::string' (or there is no acceptable conversion) — user3033831, Nov 26 '13 at 20:22

score 1 · Answer 1 · answered Nov 26 '13 at 20:21

1

You must initialize the constant members in the initializer list of ctor, and also nume._nume is not valid.

Comanda::Comanda(const string &nume) : _nume(nume) {}
                                     ^^^^^^^^^^^^^

answered Nov 26 '13 at 20:21

masoud

55,379
16
141
208

@user3033831: Actually here is night ;-) and it the answer helped you, you can _accept_ it by clicking on the green tick at left side of this answer. – masoud Nov 26 '13 at 20:56

score 0 · Answer 2 · answered Nov 26 '13 at 20:21

0

You probably meant

Comanda::Comanda(const string &nume)
{
    _nume = nume;
}

It's not a copy constructor by the way.

answered Nov 26 '13 at 20:21

jdc

319
2
5

1

While `nume._nume` is invalid, yes, you still can't do what you're suggesting, since `_nume` is `const`. – Cornstalks Nov 26 '13 at 20:22
Sorry, I missed that _nume is declared const. So you must use M M.'s solution. – jdc Nov 26 '13 at 20:25

Nik · Answer 3 · 2013-11-26T20:31:30.783

0

_nume = nume._nume; this is wrong

it should be _nume = nume;

And as correctly pointed out by @Cornstalks you cannot achieve above assignments in any case as _nume is const.

edited Nov 26 '13 at 20:31

answered Nov 26 '13 at 20:23

Nik

1,294
10
16

1

As I said to jdc, you can't assign to `_nume` since it's `const`. – Cornstalks Nov 26 '13 at 20:24

Copy constructor error c2039

3 Answers3