14

I have multiple EXECUTE IMMEDIATE commands within one oracle procedure.

EXECUTE IMMEDIATE 'DELETE  FROM tbl1'; 
EXECUTE IMMEDIATE 'INSERT INTO tbl1...'; 
COMMIT;
EXECUTE IMMEDIATE 'DELETE  FROM tbl3'; 
EXECUTE IMMEDIATE 'INSERT INTO tbl3 ...'; 
COMMIT;
EXECUTE IMMEDIATE 'DELETE  FROM tbl4'; 
EXECUTE IMMEDIATE 'INSERT INTO tbl4 ...';
COMMIT;

Do I need all of these COMMIT, or just at the end of the procedure?

Gordon Linoff
  • 1,242,037
  • 58
  • 646
  • 786
Angelina
  • 2,175
  • 10
  • 42
  • 82
  • 3
    You should only commit once when your transaction is finished - so I guess that would be at the end. –  Dec 06 '13 at 20:38

2 Answers2

10

The only times that you're really forced to commit, other thasn at the end of a business transaction, are:

  1. When executing DDL: the DDL execution is wrapped in a pair of implicit commits.
  2. After direct path insert: the table cannot be read until the insert is committed.

As horsey comments, the correct point to commit at is when the business transaction is complete. Otherwise, you need to be writing yourself some code to detect and fix partially completed and commited transactions that have left the database is a logically inconsistent state (eg. An INVOICE record exists without any INVOICE_DETAIL records).

David Aldridge
  • 51,479
  • 8
  • 68
  • 96
6

Commit is not required after every EXECUTE IMMEDIATE. Certain statements do NOT require a commit; for example, if you truncate a table with TRUNCATE. The truncation is done and there is no need for a commit. no ROLLBACK either. You need to know that COMMIT and ROLLBACK are session attributes. All uncommitted work within the current transaction are committed or rolled back - not just the statement executed by the EXECUTE IMMEDIATE.

user3752062
  • 61
  • 1
  • 4
  • 1
    Some statements are "final" - final in the sense that you do not need a "COMMIT" or "ROLLBACK". However, for execute immediate it depends on the statement that you executed. For example, if you execute an "UPDATE" or an "INSERT" or a "DELETE" you will need a "COMMIT" to commit the transaction. As noted in one of the earlier responses, COMMIT and ROLLBACK are session attributes - this means that you are COMMITing or ROLLBACKing all uncommitted transactions up to that point. Using an "EXECUTE IMMEDIATE" for a dynamic execution does NOT eliminate the need for "COMMIT" or "ROLLBACK". – user3752062 Apr 25 '20 at 05:38