Error uploading files PHP

Question

I'm trying to print the name of multiple files but uploaded array gives me nothing. What can I do?

<?php
    if (!empty($_FILES['file'])) {
        foreach ($_FILES['file']['name'] as $key => $name) {
            if ($_FILES['file']['error'][$key] == 0 && move_uploaded_file($_FILES['file']['tmp_name'][$key], "files/{$name}")) {
                $uploaded[] = $name;
            }
        }
        print_r($uploaded);
    }
?>

<!doctype html>

    <body>
        <div>
            <form action="" method="post" encype="multipart/form-data">
                <div>
                    <input type="file" name="file[]" multiple="multiple">
                    <input type="submit" value="Upload">
                </div>
            </form>
        </div>  
    </body>

Is your files array set? You may not be getting into your `if` statement — ajtrichards, Jan 02 '14 at 18:31
make sure that `$_FILES['file']['name']` exists, then make sure `$_FILES['file']['error'][$key]` exists as well, and that `move_uploaded_file` is returning `true`. One of those three things is not happening. — castis, Jan 02 '14 at 18:31
No i don't think it is. I think the problem is in the $_FILES['file'] because it is always empty. — rexhin, Jan 02 '14 at 18:35
Could it be a problem in name="file[]" multiple="multiple" ? — rexhin, Jan 02 '14 at 18:38
encype="multipart/form-data" shouldn't there be a t in there? — Jeff Hawthorne, Jan 02 '14 at 18:43
This question appears to be off-topic because it is about a typing error — George, Jan 02 '14 at 18:50
The HTML part of the example is clearly HTML5 (` `) but the “hack” of the form action being blank (` — Giacomo1968, Jan 02 '14 at 18:55

score 0 · Accepted Answer · edited May 23 '17 at 12:19

I would recommend refactoring your code like this; note the addition of two array_key_exists checks as well as an $uploaded = array(); to init the $uploaded array before the loop:

<?php
    if(!empty($_FILES['file'])) {
        $uploaded = array();
        if (array_key_exists('name', $_FILES['file'])) {
            foreach($_FILES['file']['name'] as $key => $name) {
                if(array_key_exists('error', $_FILES['file']) $_FILES['file']['error'][$key] == 0 && move_uploaded_file($_FILES['file']['tmp_name'][$key], "files/{$name}")) {
                    $uploaded[] = $name;
                }
            }
        }
        print_r($uploaded);
    }
?>

But I would also recommend doing a very basic debugging check right at the beginning of the code to see if $_FILES has anything in in:

<?php
    echo '<pre>';
    print_r($_FILES);
    echo '</pre>';
    if(!empty($_FILES['file'])) {
    …

But looking at your HTML file, your <form action="" is empty:

<form action="" method="post" encype="multipart/form-data">

What happens if you change that to:

<form action="#" method="post" encype="multipart/form-data">

Or even get rid of the action entirely:

<form method="post" encype="multipart/form-data">

I think that is the issue since your form is in HTML5 and the action="" is set, it’s never going to work. Specifically as outlined in the HTML5 spec:

The action and formaction content attributes, if specified, must have a value that is a valid URL potentially surrounded by spaces.

It was just a "t" missing in enctype="multipart/form-data" – rexhin Jan 02 '14 at 19:03 — rexhin, Jan 02 '14 at 19:03

Error uploading files PHP

1 Answers1