Singleton-Pattern for Toast, Database and other Utilities in Android

Question

As I'm really annoyed of passing the Context for most of the operations in Android (Database, Toast, Preferences). I was wondering if it's a good way of programming to initialize these elements once (e.g. in Application-Class).

It works quite good, I don't have to pass the element from Class to class and I can't see any disadvantages. Thats the reason why I wanted to ask you guys. Why shouldn't I use this?

For the people who don't know what I mean:

MainApplication:

public class MainApplication extends Application {

  @Override
  public void onCreate() {
    super.onCreate();
    VolleySingleton.init(this);
    Toaster.init(this);
    PrefUtilities.init(this);
  }
}

Toaster:

public class Toaster {
   private static Toaster mInstance = null;
   private Context context;
   private Toast currentToast;

   private Toaster(Context context) {
      this.context = context;
   }

   public static void init(Context context) {
      mInstance = new Toaster(context);
   }

   public static void toast(String message){
      if (mInstance.currentToast != null){
          mInstance.currentToast.cancel();
      }
      mInstance.currentToast = Toast.makeText(mInstance.context, message, Toast.LENGTH_SHORT);
      mInstance.currentToast.show();
   }
}

I'm also interested in the question, why the context for Toast or other stuff is needed? I can use the application context for the Toast and have access in every single Activity / Fragment. Why has the Android-Team implemented it this way?

So basically two questions:

1. Do I have any disadvantages with my implementation (memory, time) ?

2. Why do classes like Toast require a context at all?

possible duplicate of [Using Application context everywhere?](http://stackoverflow.com/questions/987072/using-application-context-everywhere) — CodingIntrigue, Jan 08 '14 at 14:48
for the first question for sure ;) but not for the second question I guess — Frame91, Jan 08 '14 at 14:51

score 2 · Accepted Answer · answered Jan 08 '14 at 14:51

2

1. Do I have any disadvantages with my implementation (memory, time) ?

Well, you are always initiating your db, even if you dont use it at all during that session, same goes for the other classes. Couldnt think of anything else, since you would use application context anyways, at least for database.

2. Why do classes like Toast require a context at all?

Toast requires a context since it touches the UiThread, so it needs a reference to access the thread.

answered Jan 08 '14 at 14:51

Daniel Bo

2,518
1
18
29

Hey thanks! to (1) - I'm always using the db as well ;), to (2): But when the ApplicationContext is good enough for the Toast, why wouldn't the Android-Team instantiate this like I did? In which case would my approach fail? – Frame91 Jan 08 '14 at 14:55
thats a good question and im sure there is some reason, at least i would like to believe that there is ^^, but without further research i cant name any =/ – Daniel Bo Jan 08 '14 at 14:58

Singleton-Pattern for Toast, Database and other Utilities in Android

1 Answers1