why this message come in php:notice undefined offset:2

Question

I want to use the project PHP Weather 2.2.2 but it has many problems here is a code

function get_languages($type) {

    static $output = array();

    if (empty($output)) {

        /* I use dirname(__FILE__) here instead of PHPWEATHER_BASE_DIR
         * because one might use this function without having included
         * phpweather.php first. */
        require(dirname(__FILE__) . '/languages.php');

        $dir = opendir(dirname(__FILE__) . '/output');
        while($file = readdir($dir)) {

            // I got a problem in  this line below     

            if (ereg("^pw_${type}_([a-z][a-z])(_[A-Z][A-Z])?\.php$", $file, $regs)) {

            // After i change it to the line mentioned below i got error undefined offset:2 in line 2 mentioned below
            // how to correct this error or is there any way to correct this code

            if(preg_match("#^pw_${type}_([a-z][a-z])(_[A-Z][A-Z])?\.php$#", $file, $regs)) {
                $output[$regs[1] . $regs[2]] = $languages[$regs[1] . $regs[2]];
            }
        }
        closedir($dir);
    }

    asort($output);

    return $output;
}

are you sure $regs[2] is existing? – Joshua Jan 15 '14 at 08:25 — Joshua, Jan 15 '14 at 08:25
`var_dump($regs);` you will get your answer. – Rikesh Jan 15 '14 at 08:27 — Rikesh, Jan 15 '14 at 08:27

Victor Bocharsky · Answer 1 · 2014-01-15T08:31:47.030

0

You see this notice because the $regs[2] is not set.

if(preg_match("#^pw_${type}_([a-z][a-z])(_[A-Z][A-Z])?\.php$#", $file, $regs)) {
    $output[$regs[1] . (isset($regs[2]) ? $regs[2] : '')] = $languages[$regs[1] . (isset($regs[2]) ? $regs[2] : '')];
}

use isset() for checking is exists an array value or no. If no exists concatenation with empty string ''

That is because you use ? in your regex (_[A-Z][A-Z])?

edited Jan 15 '14 at 08:31

answered Jan 15 '14 at 08:28

Victor Bocharsky

11,930
13
58
91

thanks.. error is remove now – user1991 Jan 15 '14 at 11:39

score 0 · Answer 2 · answered Jan 15 '14 at 08:38

Use this regular expression:

        if(preg_match("#^pw_${type}_([a-z][a-z])((?:_[A-Z][A-Z])?)\.php$#", $file, $regs)) {

The group with ?: will not be a capture group, it exists just to allow you to apply the ? modifier to it. Wrapping it in another group captures the contents of that; if the optional regexp wasn't matched, this will be an empty string.

why this message come in php:notice undefined offset:2

2 Answers2