Unable to clone class object

Question

Here is a case for which cloning of object fails:

[Serializable]
public class MasterClass
{
    public MasterClass(DataRow row)
    {
        EntityData = row;
    }

    public DataRow EntityData
    {
        get;
        set;
    }
}

for cloning I am using extention method(Clone()) from this SO question:

while cloning MasterClass object following error message thrown at runtime:

Type 'System.Data.DataRow' in Assembly 'System.Data, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' is not marked as serializable.

Any solution how to handle this?

Robert Fricke · Answer 1 · 2014-01-28T13:15:25.963

2

Try adding a parameterless constructor:

public MasterClass()
{
}

Converting DataRow

Assuming you DataRow has a Table:

[Serializable]
public class MyKeyValue {
    public string Key { get; set; }
    public string Value { get; set; }
}


[Serializable]
public class MasterClass
{
    public MasterClass() {}

    public MasterClass(DataRow row)
    {
        var list = new List<MyKeyValue>();
        foreach (DataColumn col in row.Table.Columns)
        {
            list.Add(new MyKeyValue{Key = col.ColumnName, Value = Convert.ToString(row[col.ColumnName])});
        }
        EntityData = list;
    }

    public IEnumerable<MyKeyValue> EntityData
    {
        get;
        set;
    }
}

edited Jan 28 '14 at 13:15

answered Jan 28 '14 at 12:35

Robert Fricke

3,637
21
34

The problem is not that class it is that the prop must be serializable. – Brian P Jan 28 '14 at 12:37
Constructor having `DataRow` parameter is must constructor to boot class object. Any other solution? – Ankush Madankar Jan 28 '14 at 12:57
You can have two constructors. But you also need to convert the `DataRow` to something serializable. – Robert Fricke Jan 28 '14 at 12:58
Any way to convert `DataRow` into `serializable` object? – Ankush Madankar Jan 28 '14 at 13:00
See my edit, it stores the `DataRow` as a Serializable list of object `MyKeyValue`. All values are however converted from `object` to `string`. – Robert Fricke Jan 28 '14 at 13:29

score 2 · Answer 2 · answered Jan 28 '14 at 12:38

2

Depending on what you are using the DataRow for, you will likely have to parse the values into a custom class that is serializable.

answered Jan 28 '14 at 12:38

Brian P

1,569
13
23

Is there easy way to do this rather than converting `DataRow` into custom serializable class? – Ankush Madankar Jan 28 '14 at 12:56
I like Robert Fricke's answer (post-edit). It is the classiest with least amount of work. Just remember to convert your values when using them back to what they need to be. – Brian P Jan 29 '14 at 13:47

score 1 · Answer 3 · answered Jan 28 '14 at 12:39

1

You must implement ISerializable interface - for serialization, and add constructor that takes (SerializationInfo info, StreamingContext context) - for deserialization.

answered Jan 28 '14 at 12:39

Denis

5,894
3
17
23

Unable to clone class object

3 Answers3