Switch statements from an array java

Question

Instead of me having to create a new case for each colour I decide to add, is there an alternative to using a switch statement with strings from an array as the cases? Here is my code!

public static String[][] colours = { { "red", "933" },
        { "lblue", "359770" }, { "blue", "428770" },
        { "orange", "461770" }, { "pink", "123770" } };

public static void changeColour(String col, Player player) { // changeColour("red", player);
    switch (col) {
    case "red":
        player.setColour(Integer.parseInt(colours[0][1]));
        break;
    case "lblue":
        player.setColour(Integer.parseInt(colours[1][1]));
        break;
    case "blue":
        player.setColour(Integer.parseInt(colours[2][1]));
        break;
    case "orange":
        player.setColour(Integer.parseInt(colours[3][1]));
        break;
    case "pink":
        player.setColour(Integer.parseInt(colours[4][1]));
        break;
    }
}

Possible duplicate of http://stackoverflow.com/questions/338206/switch-statement-with-strings-in-java — Alexandros, Feb 04 '14 at 20:45
@Alexandros imho, the question is not about switch for strings, but how to map one string to another (or to a number) — Andreas Fester, Feb 04 '14 at 20:47

score 6 · Accepted Answer · answered Feb 04 '14 at 20:47

Instead of the case why not use a Map instead this way you would just add to the Map and not worry about continuing the case statements for every piece

Map<String, Integer> colorMap = new HashMap<String, Integer>() {{
   put("red", 999);
   put("green", 639);
}};

Then you can just use colorMap.get("red") and it will return you the correct Integer

score 2 · Answer 2 · answered Feb 04 '14 at 20:54

another solution is using enum

enum Colour {
   red(933), blue(428770), // etc.
   ;

   int code;
   Colour(int code) {this.code = code;}
   int getCode() {return code;}
}

and rewrite your method as

void changeColour(Colour colour, Player player) {
   player.setColour(colour.getCode());
}

Silvery · Answer 3 · 2014-02-04T21:17:44.600

1

What you are looking for is a HashMap

Map<String, Integer> map = new HashMap<String, Integer>();

There is no way to use switch without explicitly setting all the cases.

edited Feb 04 '14 at 21:17

answered Feb 04 '14 at 20:52

Silvery

1,358
2
8
8

A `Map` is a useful option, but you can't use primitives with generics. – chrylis -cautiouslyoptimistic- Feb 04 '14 at 20:58
Yes, you are right. I made a mistake, and I correct it now. – Silvery Feb 04 '14 at 21:18

score 0 · Answer 4 · answered Feb 04 '14 at 20:47

0

I assume you want something like this

public static void changeColour(String col, Player player) 
{
    for(int i=0; i<colours.length; i++)
    {
        if(col.equals(colours[i][0]))
            player.setColour(Interger.parseInt(colours[i][1]);
    }
}

answered Feb 04 '14 at 20:47

Sam I am says Reinstate Monica

30,851
12
72
100

Switch statements from an array java

4 Answers4