php password system gives error

Question

I'm practicing some php and I am creating this password system. my code doesn't work. anyone notices a mistake? I think it's just a stupid fault, but i can't seem to find it.

<?php
$passwords = array("name1"   =>"pass1", 
                   "name2"   =>"pass2");

if ($password = $passwords[$username]){
setcookie("username", $username, time()+1200);
echo "<H2>Access granted.</H2>";
}
else{
    setcookie("username", "", time()-3600);
    echo "<H2>Invalid user name or password: access denied.</H2>";
}
?>

thanks everyone! my stupid fault was that i used = instead of == to check if $password is equal to $passwords[$username]

Single = in your if() should be == – JamesG Feb 14 '14 at 09:37 — JamesG, Feb 14 '14 at 09:37

score 3 · Accepted Answer · edited Feb 14 '14 at 10:33

3

<?php
$passwords = array("name1"   =>"pass1","name2"   =>"pass2");
if ($password == $passwords[$username]){
 setcookie("username", $username, time()+1200);
 echo "<H2>Access granted.</H2>";
}
else{
    setcookie("username", "", time()-3600);
    echo "<H2>Invalid user name or password: access denied.</H2>";
}
?>

You have forgot = in this row:

  if ($password == $passwords[$username]){

If you use this '=' you define this variable. But '==' it checks the variable!

edited Feb 14 '14 at 10:33

Rajeev Ranjan

4,152
3
28
41

answered Feb 14 '14 at 09:38

STP38

348
2
14

ah ofcourse, stupid mistake. thank you! – Goos van den Bekerom Feb 14 '14 at 09:40
@Goosebumbs also check for http://stackoverflow.com/questions/2063480/the-3-different-equals – Pranay Bhardwaj Feb 14 '14 at 09:42
thanks, I know the difference, I just went over it to quickly i guess. thanks everyone for answering this quickly by the way! – Goos van den Bekerom Feb 14 '14 at 09:45

score 2 · Answer 2 · answered Feb 14 '14 at 09:37

2

You are doing an assignment instead of comparison on your if statement.

Should be like

if ($password == $passwords[$username]){

Note the == instead of =

answered Feb 14 '14 at 09:37

Shankar Narayana Damodaran

68,075
43
96
126

1

**Am I getting downvotes since I answered first ?** – Shankar Narayana Damodaran Feb 14 '14 at 09:42
2

Ofcourse me too.someone is playing I think – GautamD31 Feb 14 '14 at 09:44
1

yes, don't know whats happening. I think some one is playing with us. – Pratik Feb 14 '14 at 09:45
1

I don't get it also. please know that I thank you very much for answering this quickly. they downvoted my question also so it wasn't me myself. – Goos van den Bekerom Feb 14 '14 at 09:47

score 0 · Answer 3 · answered Feb 14 '14 at 09:37

0

Use Double equal for the comparision.If you give single equal the it will only assign the right side variable to left side variable,and that to,the assigning will return always true

if ($password == $passwords[$username]){

answered Feb 14 '14 at 09:37

GautamD31

28,552
10
64
85

2

what's going on..Me and even @Shankar getting downs even we are the first – GautamD31 Feb 14 '14 at 09:41

score 0 · Answer 4 · answered Feb 14 '14 at 09:37

0

Use if like this:

if ($password == $passwords[$username]){
//code
}

answered Feb 14 '14 at 09:37

Sherin Jose

2,508
3
18
39

score 0 · Answer 5 · answered Feb 14 '14 at 09:38

0

You are using assignment operator(=) instead of equality operator(==). Replace with

if ($password == $passwords[$username])

answered Feb 14 '14 at 09:38

Jenz

8,280
7
44
77

score 0 · Answer 6 · answered Feb 14 '14 at 09:39

0

Like this

if ($password == $passwords[$username])

Use == instead of = in if statement.

answered Feb 14 '14 at 09:39

Pratik

810
6
26

2

yes, don't know whats happening. I think some one is playing with us. – Pratik Feb 14 '14 at 09:44

php password system gives error

6 Answers6