using variables in sql connection in php

Question

I use this code for connecting to sql in PHP:

public function ffff(){
    $connection = new mysql();
    $connection->connect('127.0.0.1','root','','miscfb');
}

but I want to use a variable instead of 'miscfb'.

for example: $db='miscfb';

and the code will be:

$connection->connect('127.0.0.1','root','',$db);

but it cannot connect to database!

How should I use variables?

THe new keyword is mis typed `$connection()=ne mysql();` it should be `$connection()=new mysql();` — Nouphal.M, Feb 15 '14 at 07:30
@EdHeal if it is a local development server then there wouldn't be a problem — Cjmarkham, Feb 15 '14 at 07:31
Your code isn't throwing a syntax error? Looks like bad code to me before the line in question. — jimp, Feb 15 '14 at 07:32
@CarlMarkham - I have seen it all too often that people log in as root for development and then it gets overlooked when moving it into production. Also during development people do make mistakes. Not being root can minimize that risk. — Ed Heal, Feb 15 '14 at 07:33
It appears that you're using the variable in question correctly. I would suspect some other part of your code. The following is correct assuming the class implementation is correct. $db = "miscfb"; $connection->connect('localhost','username','password?',$db); — CreationTribe, Feb 15 '14 at 07:33

Alex L · Answer 1 · 2014-02-16T22:25:55.210

0

If $db is declared inside ffff(), then that should work. If it's declared above the function, try $this->db. However if this is a connection error, instead of a variable usage question (hard to tell) then maybe you can explain an error that's being returned?

Side note: please start to move away from mysql_* and start implementing PDO or mysqli.

Quick edit! Thanks :)

edited Feb 16 '14 at 22:25

answered Feb 15 '14 at 07:32

Alex L

470
6
15

From where did concluded that the provided code sample, which is just a function, is part of a class ? – Alexandru Guzinschi Feb 15 '14 at 08:14
Probably due to the fact the code defines the visibility of the method. – Cjmarkham Feb 15 '14 at 09:57
Yes exactly? Public is not used outside of a class? Especially in PHP! – Alex L Feb 15 '14 at 15:50
My bad. I missed the `public` keyword. I can't withdraw my downvote until you edit your post. – Alexandru Guzinschi Feb 16 '14 at 20:13
It's no problem, thanks for looking at it again! – Alex L Feb 16 '14 at 22:27

score 0 · Answer 2 · answered Feb 15 '14 at 07:37

<?php
   //setting CONSTANTS for host, user, password (good practies in development step)
   DEFINE('DB_HOST', 'localhost'); 
   DEFINE('DB_USER', 'root'); 
   DEFINE('DB_PASS', 'root_pwd');  

  //storing the result of the connection (mysqli $link) in a variable 
  $dbc = mysqli_connect(DB_HOST, DB_USER, DB_PASS) or 
                    die('could not connect: '. mysqli_connect_error() );

   //storing the name of the database you want to work with
   $DB_NAME="miscfb";

  //selecting the database
  mysqli_select_db($dbc, DB_NAME) or die('could not select db');

?>

I suggest you to use Mysqli o PDO connection. Mysql "classic" connection will be deprecated on future version of PHP, that will began completely Object Oriented.

using variables in sql connection in php

2 Answers2