JSON data returns {} without any data

Question

var getfiles = function (context) {

  var scriptPath = '/var/names/myfolder';
  fs.readdir(scriptPath, function (err, files) {
    if (err) return context.sendJson(err, 404);
    var resultingJson = {};
    for (var j = 0; j < files.length; j++) {
      subfolder = scriptPath + files[j];
      console.log(files[j]);// prints art,creation
      fs.readdir(subfolder, function (err, fi) {

                //fi prints [artdetails.txt,artinfo.txt]
                        // [creationdetails.txt,create.txt]    
          //  console.log(files[j]);// prints undefined here

        resultingJson[files[j]] = fi;

      });

    }
    console.log(resultingJson); // returing {}

    context.sendJson(resultingJson, 200);
  });
}

Above code is used to fetch files inside subfolder myfolder, it contains art,creation and inside this art folder contains files artdetails.txt,artinfo.txt creation folder contains files creationdetails.txt,create.txt etc.

Folder and files are fetching successfully but I want to generate a JSON format like this:

{`art':['artdetails',artinfo],'creation':['creationdetails','create']} format

How it is possible?

I used resultingJson[files[j]] = fi; but it returns{}.

What is wrong with my code?

`readdir` is **asynchronous**. You are calling `context.sendJson(resultingJson, 200);` before the directories are read. Please see [How to return the response from an AJAX call?](http://stackoverflow.com/q/14220321/218196) for an explanation and solution (even if it is about Ajax, the concepts are the same). — Felix Kling, Feb 20 '14 at 08:00
i read the article but i dont know what change do in my code?how can i change this? — Sush, Feb 20 '14 at 08:07

score 2 · Answer 1 · answered Feb 20 '14 at 08:22

You care resetting the value of resultingJson to {} inside a recursive function.

try this code

var getfiles = function (context) {

  var scriptPath = '/var/names/myfolder';
  var resultingJson = {};
  fs.readdir(scriptPath, function (err, files) {
    if (err) return context.sendJson(err, 404);
    for (var j = 0; j < files.length; j++) {
      subfolder = scriptPath + files[j];
      console.log(files[j]);// prints art,creation
      fs.readdir(subfolder, function (err, fi) {

                //fi prints [artdetails.txt,artinfo.txt]
                        // [creationdetails.txt,create.txt]    
          //  console.log(files[j]);// prints undefined here

        resultingJson[files[j]] = fi;

      });

    }
    console.log(resultingJson); // returing {}

    context.sendJson(resultingJson, 200);
  });
}

How many times are you seeing console.log printing on console? — SajithNair, Feb 20 '14 at 08:29

Kevin Reilly · Accepted Answer · 2014-02-20T11:40:12.703

There are a few problems here. First and foremost, Felix Kling made the correct observation about readdir being async, more specifically referring to the inner readdir within the for loop. Part of what you are seeing is that your console.log and JSON response is occurring before the directories have finished being read. Also what is likely occurring is the context of j is being lost, likely ending up the last value.

A control flow library like async may help, such as the each method.

var fs = require('fs'),
    async = require('async');

var scriptPath = '/var/names/myfolder';

var getfiles = function(context) {
  // Read contents of the parent directory
  fs.readdir(scriptPath, function(err, files) {
    if (err) return context.sendJson(err, 404);
    var result = {};
    // Asynchronously iterate over the directories
    async.each(files, function iterator(directory, next){
      var subfolder = scriptPath + directory;
      // Read contents of the child directory
      fs.readdir(subfolder, function(err, file){
        if (err) return next(err);
        // Set the property
        result[directory] = file;
        // Now that we've finished reading these contents,
        // lets read the contents of the next child folder
        next();
        // When there are none left, the `complete` callback will
        // be reached and then it is safe to return a JSON string
      });
    }, function complete(err){
      // All children directories have been read
      // and the `result` object should be what we expect
      if (err) return context.sendJson(err, 404);
      context.sendJson(result, 200);
    });
  });
};

I have tested this by mocking your folder/file structure and it appears to work properly. It produced the following JSON string:

{"art":["artdetails.txt","artinfo.txt"],"creation":["create.txt","creationdetails.txt"]}

The iterators are called in parallel, so the order may switch, but it shouldn't make a difference.

My pleasure. The async module has a great suite of tools, should definitely check out the other methods when you have some time. — Kevin Reilly, Feb 20 '14 at 11:40
is this s good methos of using ` var file = fs.readdirSync(files);` — Sush, Feb 20 '14 at 11:46
That could work also. I generally try to avoid sync where I can. — Kevin Reilly, Feb 20 '14 at 12:29

score 0 · Answer 3 · answered Feb 20 '14 at 08:48

Please try the other way:

fs.readdir(scriptPath, function (err, files) {
    if (err) return context.sendJson(err, 404);
    files.forEach(function(file) {
      subfolder = scriptPath + file;
      console.log(file);
      fs.readdir(subfolder, function (err, fi) {
        resultingJson[file] = fi;
      });

    }
console.log(resultingJson);
context.sendJson(resultingJson, 200);
});

JSON data returns {} without any data

3 Answers3