Getting data from an Activity in a Fragment

Question

I've set up a fragment inside my activity, but I'm wondering how I can pass data from the activity into the fragment?

For example, this is my code:

    public class MyFragment extends Fragment 
{   
    private MyData _myData;

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) 
    {   
        // Inflate the layout for this fragment 
        return inflater.inflate(R.layout.custom_fragment, container, false);

        MyActivity activity = (MyActivity) getActivity(); // Unreachable code error here
        _myData = activity.getMyData();
    }
}

I need to be able to access the contents of the MyData object in the fragment. But when I try this code above, I get an "Unreachable Code" error, even though getMyData() is a public method in the MyActivity class.

score 5 · Accepted Answer · edited Feb 21 '14 at 11:22

5

This line is the problem

return inflater.inflate(R.layout.custom_fragment_make_assembly_machine_location, container, false);

The return statement makes the function... return!, so following code never gets executed!

edited Feb 21 '14 at 11:22

BenMorel

34,448
50
182
322

answered Feb 21 '14 at 08:05

Merlevede

8,140
1
24
39

How could I have missed that! Thanks, that of course fixed it :) – b85411 Feb 21 '14 at 08:20

score 2 · Answer 2 · edited May 23 '17 at 11:50

You have a return statement before

MyActivity activity = (MyActivity) getActivity();

Move the return statement to the last

@Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) 
    {   
        MyActivity activity = (MyActivity) getActivity(); 
        _myData = activity.getMyData();
        return inflater.inflate(R.layout.custom_fragment, container, false);
    }

Also you may want to check

Send data from activity to fragment in android

Getting data from an Activity in a Fragment

2 Answers2