function not working properly on android

Question

I have a little problem with a function I'm using on an android app. Ihe function is not too hard, it's just a simple calculation with two random integers. The problem is that I have a label that I want to change the text of into the "problem" so that the user can solve it. I know something is wrong with the function but I can't quite figure out what. My closest guess is that the return part is wrong (since it's null), but I couldn't fix it in anyway so far.

This is my code:

import java.util.Random;
import android.app.Activity;
import android.os.Bundle;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.TextView;

public class Game extends Activity implements OnClickListener {

private static final String TAG = "Game";

int game[];

public static final String KEY_DIFFICULTY = "com.example.coursework1.dificulty";

public static final int DIFFICULTY_NOVICE = 0;
public static final int DIFFICULTY_EASY = 1;
public static final int DIFFICULTY_MEDIUM = 2;
public static final int DIFFICULTY_GURU = 3;

protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.game);

    int diff = getIntent().getIntExtra(KEY_DIFFICULTY, DIFFICULTY_NOVICE);
    game = getGame(diff);


}

public int[] getGame(int diff) {
    // TODO Auto-generated method stub
    String operators [] =  {"+","-","*","/"};
    Random op1, op2, op3, op4, op5, op6;
    if(diff == getIntent().getIntExtra(KEY_DIFFICULTY, DIFFICULTY_NOVICE)){
        op1 = new Random();
        op2 = new Random();
        int operator = new Random().nextInt(operators.length);
        String random = (operators[operator]);
        int generate1 = op1.nextInt(10);
        int generate2 = op2.nextInt(10);
        int operation;
        if(random == "+"){
            operation = generate1 + generate2;
            TextView setProblemToView = (TextView) findViewById(R.id.problem);
            setProblemToView.setText("generate1" + random + "generate2");
        }
    }


    return null;
}

@Override
public void onClick(View arg0) {
    // TODO Auto-generated method stub
}
}

Note: don't compare String values using `==`. Use `equals()`. — Alexis C., Feb 23 '14 at 21:29
what goes wron here is that when i test the app on the avd, the value of the problem string is still the same (which is problem). — jPratas, Feb 23 '14 at 21:31
possible duplicate of [How do I compare strings in Java?](http://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java) — anddev84, Feb 23 '14 at 21:31
It's working well now. I'm sorry everyone, I'm still kind of a noob in coding :) — jPratas, Feb 23 '14 at 21:37

score 0 · Accepted Answer · edited May 23 '17 at 11:57

Why using int ruturn while you have to return always null? use it like that:

public void getGame(int diff) {

    String operators [] =  {"+","-","*","/"};
    Random op1, op2, op3, op4, op5, op6;
    if(diff == getIntent().getIntExtra(KEY_DIFFICULTY, DIFFICULTY_NOVICE)){
        op1 = new Random();

        int operator = new Random().nextInt(operators.length);
        String random = (operators[operator]);
        int generate1 = op1.nextInt(10);
        int generate2 = op1.nextInt(10);
        int operation;
        if(  "+".equalsIgnoreCase(random) ){
            operation = generate1 + generate2;
            TextView setProblemToView = (TextView) findViewById(R.id.problem);
            setProblemToView.setText("generate1" + random + "generate2");
        }
    }

}

and call it just like that:

getGame(diff);

Same random problem solved in my edits, check that for more

Oh of course. It was right in fron of me and I wasn't seeing it. Thanks :) — jPratas, Feb 23 '14 at 22:35

function not working properly on android

1 Answers1